Fixes T8616. The rules for contributors have come up a few times recently, so update this document to give more complete advice.
Also try to do a better job with "adding new classes" (previously: libphutil libraries blah blah no one cares).
Details
Details
- Reviewers
joshuaspence btrahan - Maniphest Tasks
- T8616: Write a guide for translatable strings
- Commits
- Restricted Diffusion Commit
rP85083c88c104: Update the translations document
Read documents.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think these docs are great. :D
| src/docs/contributor/adding_new_classes.diviner | ||
|---|---|---|
| 238 | Maybe a Next Steps"See Community Resources for links to install scripts, extensions, libraries, and plugins for Phabricator and Arcanist, maintaind by the community. Note that we do not support extension development so you may have mixed luck with this one." ? | |
| src/docs/contributor/internationalization.diviner | ||
| 263 | do you need an "and" at the end? This sentence read a little muddled to me. | |
| src/docs/contributor/adding_new_classes.diviner | ||
|---|---|---|
| 44 | Maybe extend this to match the length of the title from the previous line? Personally, I prefer = Extensions Directory =. | |
| 78 | As above. | |
| 99 | This seems odd to me to be in bold. | |
| 109 | This seems a little inconsistent, previously you used ``` (for the above PHP code block) and here you have used indentation. | |
| 155 | Maybe add lang=json for syntax highlighting. | |
| 206 | "Break you frequently" reads really odd to me. | |
| src/docs/user/userguide/arcanist_lint_unit.diviner | ||
| 44 | Add lang=json | |