Description
Description
Details
Details
- Auditors
joshuaspence - Group Auditors
Cowboy Commits - Provenance
epriestley Authored on epriestley Pushed on Jun 15 2015, 8:39 PM - Parents
- rARCfe4856277c6c: Add some tests for subclasses
- Branches
- Unknown
- Tags
- Tasks
- T8554: PHPUnit tests cause failure
Event Timeline
| /src/unit/parser/ArcanistPhpunitTestResultParser.php | ||
|---|---|---|
| 96 | This variable can be unitialized when there are no reports, resulting in arc aborting with: EXCEPTION: (RuntimeException) Undefined variable: last_test_finished at [<phutil>/src/error/PhutilErrorHandler.php:210] arcanist(head=master, ref.master=d54cb072facd), deviantart(), phutil(head=master, ref.master=75f675747648) #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<arcanist>/src/unit/parser/ArcanistPhpunitTestResultParser.php:95] #1 ArcanistPhpunitTestResultParser::parseTestResults(string, string) called at [<deviantart>/unit/DaUnitEngine.php:150] #2 DaUnitEngine::parseTestResults(string, TempFile, string, string) called at [<deviantart>/unit/DaUnitEngine.php:82] #3 DaUnitEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:186] #4 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382] It would help if it were initialized to true before looping through the reports. | |