Page MenuHomePhabricator

Dramatically limit the range of failures which can cause duplicate mail
ClosedPublic

Authored by epriestley on Jun 16 2015, 11:22 PM.
Tags
None
Referenced Files
F13192299: D13320.diff
Sun, May 12, 6:42 AM
Unknown Object (File)
Wed, May 1, 5:21 PM
Unknown Object (File)
Tue, Apr 16, 3:27 AM
Unknown Object (File)
Apr 7 2024, 2:45 AM
Unknown Object (File)
Apr 5 2024, 3:55 PM
Unknown Object (File)
Apr 4 2024, 8:16 PM
Unknown Object (File)
Apr 3 2024, 2:20 PM
Unknown Object (File)
Apr 1 2024, 9:10 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

Ref T8574. Currently, failures during mail body construction, feed publishing, or search indexing could cause us to retry the publishing task and potentially send duplicate mail.

Instead, build (but do not send) the mail first, then send all the mail at the very end.

This isn't completley perfect, but should make it enormously harder for duplicate mail to be generated.

Test Plan

Sent some mail, ran the daemons, saw it show up normally in the outbound queue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Dramatically limit the range of failures which can cause duplicate mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 11:25 PM
This revision was automatically updated to reflect the committed changes.