Differential D13347

Truncate large strings in DarkConsole
ClosedPublic
Actions

Authored by epriestley on Jun 18 2015, 7:23 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8597: PDF fails to display for download

Commits

Restricted Diffusion Commit
rP2eb73619d1c4: Truncate large strings in DarkConsole

Summary

Ref T8597. If a page issues a large query (like inserting a blob into file storage), we may try to utf8ize the entire thing. This is slow and pointless.

Instead, truncate tab data after 4096 bytes before sanitizing.

Test Plan

Adjusted limit to 256 bytes, saw long queries get truncated reasonably.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32291.Jun 18 2015, 7:23 PM

epriestley retitled this revision from to Truncate large strings in DarkConsole.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8597: PDF fails to display for download.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 18 2015, 7:23 PM

btrahan accepted this revision.Jun 18 2015, 7:54 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 18 2015, 7:54 PM

epriestley mentioned this in T8597: PDF fails to display for download.Jun 18 2015, 8:01 PM

Closed by commit rP2eb73619d1c4: Truncate large strings in DarkConsole (authored by epriestley, committed by epriestley). · Explain WhyJun 18 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

console/

core/

DarkConsoleCore.php

7 lines

Diff 32294

View Options

src/applications/console/core/DarkConsoleCore.php

Truncate large strings in DarkConsoleClosedPublicActions