Page MenuHomePhabricator

Truncate large strings in DarkConsole
ClosedPublic

Authored by epriestley on Jun 18 2015, 7:23 PM.
Tags
None
Referenced Files
F15471210: D13347.id32294.diff
Sat, Apr 5, 4:08 AM
F15464923: D13347.id32294.diff
Wed, Apr 2, 1:06 PM
F15434701: D13347.id32294.diff
Tue, Mar 25, 4:56 AM
F15409651: D13347.id32294.diff
Mar 19 2025, 4:49 AM
F15407511: D13347.id32291.diff
Mar 18 2025, 5:56 PM
F15403058: D13347.id.diff
Mar 18 2025, 1:46 AM
F15402982: D13347.id32291.diff
Mar 18 2025, 1:28 AM
F15402880: D13347.id32294.diff
Mar 18 2025, 12:49 AM
Subscribers

Details

Summary

Ref T8597. If a page issues a large query (like inserting a blob into file storage), we may try to utf8ize the entire thing. This is slow and pointless.

Instead, truncate tab data after 4096 bytes before sanitizing.

Test Plan

Adjusted limit to 256 bytes, saw long queries get truncated reasonably.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Truncate large strings in DarkConsole.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.