Differential D13316

Phriction - improve workflow for when user entered slug needs to be normalized.
ClosedPublic
Actions

Authored by btrahan on Jun 16 2015, 10:05 PM.

Tags

None

Referenced Files

	F17838294: D13316.id.diff
	Sat, Jul 26, 6:27 PM

	F17764133: D13316.diff
	Wed, Jul 23, 12:17 AM

	Unknown Object (File)
	Jun 19 2025, 12:58 PM

	Unknown Object (File)
	Apr 26 2025, 11:39 PM

	Unknown Object (File)
	Apr 25 2025, 4:45 AM

	Unknown Object (File)
	Apr 24 2025, 10:50 PM

	Unknown Object (File)
	Apr 20 2025, 6:58 AM

	Unknown Object (File)
	Apr 14 2025, 9:14 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPdb9fc369ca62: Phriction - improve workflow for when user entered slug needs to be normalized.

Summary

Encountered this playing with T8402 on my test instance. I think warning the user about adding a trailing "/" is unnecessary so don't do it. I think its confusing to not call out spaces / to lump them in with special characters so call out the sapces.

Test Plan

moved a page around and verified no warning if the slug is missing a "/" as user specified and that a change to spaces is called out

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 32227.Jun 16 2015, 10:05 PM

btrahan retitled this revision from to Phriction - improve workflow for when user entered slug needs to be normalized..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 10:05 PM

epriestley accepted this revision.Jun 16 2015, 10:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 10:31 PM

Closed by commit rPdb9fc369ca62: Phriction - improve workflow for when user entered slug needs to be normalized. (authored by btrahan, committed by btrahan). · Explain WhyJun 16 2015, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionMoveController.php

5 lines

Diff 32229

src/applications/phriction/controller/PhrictionMoveController.php

Loading...