Page MenuHomePhabricator

Phriction - improve workflow for when user entered slug needs to be normalized.
ClosedPublic

Authored by btrahan on Jun 16 2015, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 11:24 AM
Unknown Object (File)
Sat, Dec 7, 6:40 AM
Unknown Object (File)
Fri, Dec 6, 2:53 PM
Unknown Object (File)
Wed, Dec 4, 7:17 PM
Unknown Object (File)
Tue, Dec 3, 12:30 PM
Unknown Object (File)
Oct 26 2024, 11:02 AM
Unknown Object (File)
Oct 20 2024, 10:14 PM
Unknown Object (File)
Oct 13 2024, 12:34 AM
Subscribers

Details

Summary

Encountered this playing with T8402 on my test instance. I think warning the user about adding a trailing "/" is unnecessary so don't do it. I think its confusing to not call out spaces / to lump them in with special characters so call out the sapces.

Test Plan

moved a page around and verified no warning if the slug is missing a "/" as user specified and that a change to spaces is called out

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Phriction - improve workflow for when user entered slug needs to be normalized..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.