Page MenuHomePhabricator

Phriction - improve workflow for when user entered slug needs to be normalized.
ClosedPublic

Authored by btrahan on Jun 16 2015, 10:05 PM.
Tags
None
Referenced Files
F15520482: D13316.id32227.diff
Sun, Apr 20, 6:58 AM
F15503342: D13316.id.diff
Mon, Apr 14, 9:14 AM
F15404399: D13316.id32229.diff
Mar 18 2025, 7:33 AM
F15399814: D13316.diff
Mar 17 2025, 7:52 AM
F15369589: D13316.id32227.diff
Mar 12 2025, 7:22 AM
F15367585: D13316.diff
Mar 11 2025, 7:58 PM
F15283254: D13316.diff
Mar 4 2025, 6:26 AM
Unknown Object (File)
Feb 11 2025, 9:30 PM
Subscribers

Details

Summary

Encountered this playing with T8402 on my test instance. I think warning the user about adding a trailing "/" is unnecessary so don't do it. I think its confusing to not call out spaces / to lump them in with special characters so call out the sapces.

Test Plan

moved a page around and verified no warning if the slug is missing a "/" as user specified and that a change to spaces is called out

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Phriction - improve workflow for when user entered slug needs to be normalized..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.