Differential D13316

Phriction - improve workflow for when user entered slug needs to be normalized.
ClosedPublic
Actions

Authored by btrahan on Jun 16 2015, 10:05 PM.

Tags

None

Referenced Files

	F18812944: D13316.diff
	Mon, Oct 20, 1:06 PM

	F18763186: D13316.id32229.diff
	Mon, Oct 6, 11:06 PM

	F18750242: D13316.id32227.diff
	Sat, Oct 4, 7:05 AM

	F18748200: D13316.id.diff
	Fri, Oct 3, 7:46 PM

	F18746849: D13316.id32227.diff
	Fri, Oct 3, 1:39 PM

	F18745757: D13316.diff
	Fri, Oct 3, 9:13 AM

	F18745461: D13316.id.diff
	Fri, Oct 3, 7:10 AM

	F18745357: D13316.diff
	Fri, Oct 3, 6:21 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPdb9fc369ca62: Phriction - improve workflow for when user entered slug needs to be normalized.

Summary

Encountered this playing with T8402 on my test instance. I think warning the user about adding a trailing "/" is unnecessary so don't do it. I think its confusing to not call out spaces / to lump them in with special characters so call out the sapces.

Test Plan

moved a page around and verified no warning if the slug is missing a "/" as user specified and that a change to spaces is called out

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 32227.Jun 16 2015, 10:05 PM

btrahan retitled this revision from to Phriction - improve workflow for when user entered slug needs to be normalized..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 10:05 PM

epriestley accepted this revision.Jun 16 2015, 10:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 10:31 PM

Closed by commit rPdb9fc369ca62: Phriction - improve workflow for when user entered slug needs to be normalized. (authored by btrahan, committed by btrahan). · Explain WhyJun 16 2015, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionMoveController.php

5 lines

Diff 32229

src/applications/phriction/controller/PhrictionMoveController.php

Loading...