Differential D13314

Conpherence - fix a bug where users have no events
ClosedPublic
Actions

Authored by btrahan on Jun 16 2015, 9:35 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8518: InvalidArgumentException when re-joining a previously left Conpherence room

Commits

Restricted Diffusion Commit
rP281082f4d730: Conpherence - fix a bug where users have no events

Summary

Fixes T8518. Defaulting $events to null creates carnage further down the stack. Instead, default it to array() so foreach, array_select_keys, etc. don't barf.

Test Plan

logic and will ask the reporting user to verify since they can repro 100%

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 32223.Jun 16 2015, 9:35 PM

btrahan added a task: T8518: InvalidArgumentException when re-joining a previously left Conpherence room.

btrahan retitled this revision from to Conpherence - fix a bug where users have no events.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 9:35 PM

epriestley accepted this revision.Jun 16 2015, 9:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 9:36 PM

Closed by commit rP281082f4d730: Conpherence - fix a bug where users have no events (authored by btrahan, committed by btrahan). · Explain WhyJun 16 2015, 9:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadQuery.php

3 lines

Diff 32224

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Conpherence - fix a bug where users have no eventsClosedPublicActions