Page MenuHomePhabricator

Improve Differential query plans
ClosedPublic

Authored by epriestley on Jun 17 2015, 3:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 3:00 AM
Unknown Object (File)
Jan 26 2024, 11:15 PM
Unknown Object (File)
Dec 22 2023, 10:50 PM
Unknown Object (File)
Dec 16 2023, 2:18 PM
Unknown Object (File)
Nov 29 2023, 11:27 PM
Unknown Object (File)
Nov 25 2023, 3:36 AM
Unknown Object (File)
Nov 25 2023, 1:40 AM
Unknown Object (File)
Nov 14 2023, 11:38 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T8575: Reap easy performance improvements
Commits
Restricted Diffusion Commit
rPb3ae48d8ca2d: Improve Differential query plans
Summary

Ref T8575. We run a big "(A) UNION (B)" query on the home page and on the main Differential page.

"A" can always be improved by using %Ls, so it can use the second half of the (authorPHID, status) key.

"B" can sometimes be improved if the fraction of open revisions is smaller than the fraction of revisions you are reviewing. This is true for me on secure.phabricator.com (I'm a reviewer, either directly or via 'Blessed Reviewers', on about 80% of revisions, but <5% are open). In these cases, a (status, phid) key is more efficient.

Test Plan

Tweaked queries and added keys on this server, saw less derpy query plans and performance.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve Differential query plans.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2015, 6:06 PM
This revision was automatically updated to reflect the committed changes.