Page MenuHomePhabricator
Feed Advanced Search

May 21 2015

epriestley closed T8283: Error thrown when opening a file in Diffusion's file browser as Resolved by committing Restricted Diffusion Commit.
May 21 2015, 4:28 PM · Diffusion
epriestley closed T8260: Differential Repositories are linking to non-existent symbols as Resolved by committing Restricted Diffusion Commit.
May 21 2015, 3:25 PM · Symbols
epriestley added a revision to T8243: Escape console output more thoroughly: Unknown Object (Differential Revision).
May 21 2015, 3:23 PM · Infrastructure
epriestley claimed T8277: Image transformation may race itself for long/slow transforms.
May 21 2015, 2:50 PM · Files
epriestley added a revision to T8277: Image transformation may race itself for long/slow transforms: Unknown Object (Differential Revision).
May 21 2015, 2:50 PM · Files
epriestley added a comment to T8282: What is the purpose of creating an admin account?.

Here is the expected workflow when you login with your newly created administrative account. First, you'll see the home screen like this (note the red callout about unresolved setup issues):

May 21 2015, 2:37 PM · Setup
epriestley added a revision to T8283: Error thrown when opening a file in Diffusion's file browser: Unknown Object (Differential Revision).
May 21 2015, 2:30 PM · Diffusion
epriestley claimed T8283: Error thrown when opening a file in Diffusion's file browser.
May 21 2015, 2:30 PM · Diffusion
epriestley closed T8286: Press quick keyboard shortcut to focus main search bar, or open search modal as Resolved.
  • Press / to focus the search input.
  • Configure this setting in Settings → Search Preferences.
  • Press ? for a list of keyboard commands.
May 21 2015, 2:27 PM · Search
epriestley triaged T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty as Normal priority.

Yeah, this is a bug with the interaction between offsets and limits in the underlying fulltext search query (which finds documents matching the search terms) and policy-aware, cursor-based paging in the application-level query (which filters out documents you can't see). I wasn't able to find a clean fix in 5 minutes of poking at it.

May 21 2015, 2:25 PM · Search
epriestley updated subscribers of T3670: Add subprojects.
May 21 2015, 2:09 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley merged task T8284: Tasks could have keywords added into T3670: Add subprojects.
May 21 2015, 2:09 PM · Maniphest
epriestley reopened T3670: Add subprojects as "Open".
May 21 2015, 2:09 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley reopened T3670: Add subprojects, a subtask of T6634: Typeahead default should maybe be more than 5, as Open.
May 21 2015, 2:09 PM · Typeahead, Maniphest
epriestley reopened T3670: Add subprojects, a subtask of T6579: Display hovercards on Tokens in Typeaheads, as Open.
May 21 2015, 2:09 PM · Hovercards, PHUI
• altan awarded T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges a Like token.
May 21 2015, 5:06 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

May 20 2015

epriestley closed T8279: Password shown in plain text. Hidden makes it locked. as Wontfix.

Cool. Let us know if you run into anything eles.

May 20 2015, 10:14 PM · Config
epriestley added a comment to T8279: Password shown in plain text. Hidden makes it locked..

The username is also locked, and can not be edited from the web UI.

May 20 2015, 9:34 PM · Config
epriestley closed T8274: Misconfigured Elasticsearch can fatal the setup issue process as Resolved by committing Restricted Diffusion Commit.
May 20 2015, 9:21 PM · Setup, Search
epriestley closed T5703: Simplify amount of domain configuration as Resolved by committing Restricted Diffusion Commit.
May 20 2015, 9:21 PM · Support Impact, Setup
epriestley added a comment to T8279: Password shown in plain text. Hidden makes it locked..

Can you walk me through a deployment scenario where changing the password from the web UI is necessary, but changing the username, host, port, etc., are not? I can't come up with a case where this makes sense.

May 20 2015, 9:19 PM · Config
epriestley updated subscribers of T6367: Send email with recipient's language and access levels, not sender's.
May 20 2015, 6:25 PM · Wikimedia, Security, Localization, Mail
epriestley merged task T8280: email notifications appear to bypass some project visibility rules into T6367: Send email with recipient's language and access levels, not sender's.
May 20 2015, 6:25 PM
epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

Filed as T8277.

May 20 2015, 3:56 PM · Restricted Project, Macros, Files
epriestley added a comment to T8277: Image transformation may race itself for long/slow transforms.

since it's a huge GIF with a bunch of text on it.

May 20 2015, 3:55 PM · Files
epriestley created T8277: Image transformation may race itself for long/slow transforms.
May 20 2015, 3:54 PM · Files
epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

I'll file that separately.

May 20 2015, 3:52 PM · Restricted Project, Macros, Files
epriestley triaged T8276: Diffusion shows no author information if it was associated with a deleted user as Wishlist priority.

We strongly recommend you disable (rather than delete) users for this reason. This is explained in the prompt when you try to delete a user.

May 20 2015, 3:51 PM · Restricted Project, Diffusion
epriestley added a comment to T8275: Assess impact of "Logjam" attack on Diffie-Helman / TLS.
  • secure.phabricator.com does not support export-grade (weak) ciphers, and is safe from the brunt of this attack.
  • nlb*.phacility.com is terminated by the notification server, which does not support export-grade (weak) ciphers, and is safe from the brunt of this attack.
  • *.phacility.com is terminated by ELBs, which do not support weak ciphers as configured, but do use a common 1024-bit DH group. This means connections could theoretically be compromised by state-level actors. I think we can't address this directly (we can configure cipher suites, but not the DH group). I haven't found AWS issuing any guidance on it yet. I would expect them to remedy the issue or provide guidance on it in the next few days; if not, we can evaluate running software loadbalancers instead of ELBs (this is a fair amount of work, but we already run software LBs on the vault tier and terminate our own SSL on the nlb tier).
May 20 2015, 3:02 PM · Security
epriestley created T8275: Assess impact of "Logjam" attack on Diffie-Helman / TLS.
May 20 2015, 2:44 PM · Security
epriestley added a comment to T8274: Misconfigured Elasticsearch can fatal the setup issue process.

You may be able to run this command:

May 20 2015, 2:38 PM · Setup, Search
epriestley updated subscribers of T8099: Mid-2015 Phabricator Redesign.
May 20 2015, 2:25 PM · Design
epriestley merged task T8239: 2015 Redesign into T8099: Mid-2015 Phabricator Redesign.
May 20 2015, 2:25 PM · Design
epriestley edited subtasks for T5752: Navigation menus should work correctly on mobile by default, added: T8099: Mid-2015 Phabricator Redesign; removed: T8239: 2015 Redesign.
May 20 2015, 2:25 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley removed a parent task for T8239: 2015 Redesign: T5752: Navigation menus should work correctly on mobile by default.
May 20 2015, 2:25 PM · Design
epriestley added a parent task for T8099: Mid-2015 Phabricator Redesign: T5752: Navigation menus should work correctly on mobile by default.
May 20 2015, 2:25 PM · Design
epriestley removed a parent task for T8239: 2015 Redesign: T8175: Mobile always collapses long crumbs.
May 20 2015, 2:25 PM · Design
epriestley edited subtasks for T8175: Mobile always collapses long crumbs, added: T8099: Mid-2015 Phabricator Redesign; removed: T8239: 2015 Redesign.
May 20 2015, 2:25 PM · Mobile, PHUI
epriestley added a parent task for T8099: Mid-2015 Phabricator Redesign: T8175: Mobile always collapses long crumbs.
May 20 2015, 2:25 PM · Design
epriestley closed T8110: project ACL dropdowns cause native & kappa twitch scrollbar to both appear as Resolved.

This is presumably obsoleted by the new scrollbar behavior.

May 20 2015, 2:24 PM · PHUI, Policy
epriestley closed T8143: Allow creation of Conduit API Tokens for bots as Resolved.

Presuming resolved since I'm pretty sure this works properly.

May 20 2015, 2:21 PM · Conduit
epriestley claimed T5703: Simplify amount of domain configuration.
May 20 2015, 2:15 PM · Support Impact, Setup
epriestley added a revision to T5703: Simplify amount of domain configuration: Unknown Object (Differential Revision).
May 20 2015, 2:13 PM · Support Impact, Setup
epriestley closed T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support as Resolved.

This seems to be in relatively good shape. Some possible future work:

May 20 2015, 2:05 PM · Support Impact, Setup
epriestley closed T8272: Allow at least some class of admins to edit other user's settings as Wontfix.

Placing severe limits on the power of administrators is an intentional design decision. See here for discussion:

May 20 2015, 1:37 PM
epriestley closed T8270: Restrict 'Assigned to' and 'CC' field user drop downs as Wontfix.

Even T3820 won't necessarily fix this. We don't currently plan to implement this level of siloing, although we may pursue it after T3820. If you need to prevent users from knowing that other users exist, Phabricator may not be the best tool for your purposes.

May 20 2015, 1:32 PM · Maniphest
epriestley updated subscribers of T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
May 20 2015, 1:30 PM · Spaces, Policy, Wikimedia
epriestley merged task T8271: Changing default 'Visible to' and 'Editable by' fields into T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
May 20 2015, 1:30 PM · Maniphest
epriestley added a comment to T8271: Changing default 'Visible to' and 'Editable by' fields.

Yes, we plan to address this use case via "Spaces", see T3820.

May 20 2015, 1:30 PM · Maniphest
epriestley renamed T8274: Misconfigured Elasticsearch can fatal the setup issue process from Curl Error to Misconfigured Elasticsearch can fatal the setup issue process.
May 20 2015, 1:24 PM · Setup, Search
epriestley added a revision to T8274: Misconfigured Elasticsearch can fatal the setup issue process: Unknown Object (Differential Revision).
May 20 2015, 1:23 PM · Setup, Search
epriestley closed T8269: Phabricator likes to send empty emails as Wontfix.

LLVM has custom code which is doing this. Upstream Phabricator does not send email which looks like this.

May 20 2015, 4:45 AM
epriestley awarded T7936: Give Calendar events custom icons a Mountain of Wealth token.
May 20 2015, 12:05 AM · Calendar
epriestley added a comment to T7936: Give Calendar events custom icons.

I love them so much

May 20 2015, 12:04 AM · Calendar
epriestley changed the icon for E974: Feed Kitty Cat Again from Default to Pet Activity.
May 20 2015, 12:02 AM

May 19 2015

epriestley created T8266: Some audio isn't streaming correctly in Safari.
May 19 2015, 11:34 PM · Safari, Files
epriestley closed T8265: Project doesn't display Custom Policy as Invalid.

The header shows the view policy, not the edit policy.

May 19 2015, 11:29 PM · Projects
btrahan awarded T8227: Why not just add an option/setting/preference? a Like token.
May 19 2015, 9:02 PM · Guides
epriestley closed T8150: Phriction document actions should be a real dropdown as Resolved by committing Restricted Diffusion Commit.
May 19 2015, 7:14 PM · Phriction
epriestley closed T8261: bla as Invalid.
May 19 2015, 7:14 PM · Facebook
epriestley added a revision to T8150: Phriction document actions should be a real dropdown: Unknown Object (Differential Revision).
May 19 2015, 7:05 PM · Phriction
qgil awarded T8157: General search no longer respects custom priorities a Like token.
May 19 2015, 6:51 PM · Search
epriestley added a comment to T8260: Differential Repositories are linking to non-existent symbols.

That Herald rule is clever!

May 19 2015, 6:39 PM · Symbols
epriestley claimed T8150: Phriction document actions should be a real dropdown.
May 19 2015, 6:32 PM · Phriction
epriestley added a comment to T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.

First thought is to do this:

May 19 2015, 6:29 PM · Prioritized, Drydock
epriestley added a comment to T8216: Make mailKey-related errors more obvious when testing new mail code.

Yeah, on further thought I suspect the magical config is just metamta.reply-handler-domain not being set.

May 19 2015, 6:26 PM · Projects
epriestley closed T8157: General search no longer respects custom priorities as Resolved.

Presuming this is resolved because the new feature is a superset of the old feature.

May 19 2015, 6:23 PM · Search
epriestley closed T8196: cburrough's total normal ticket as Resolved.

(I don't think we need this to repro anything.)

May 19 2015, 6:22 PM · Restricted Project
epriestley added a comment to T8216: Make mailKey-related errors more obvious when testing new mail code.

There's also no actual technical reason that objects legitimately need to have a mailKey at the PhabricatorMailReplyHandler level right now.

May 19 2015, 6:18 PM · Projects
epriestley closed T8216: Make mailKey-related errors more obvious when testing new mail code as Wontfix.

I can't actually figure out what configuration avoids this error -- metamta.public-replies on and off both try to call getMailKey() for me.

May 19 2015, 6:16 PM · Projects
epriestley closed T8221: Firefox failed to display the embded image correctly (while chrome does mange it) as Resolved by committing Restricted Diffusion Commit.
May 19 2015, 6:08 PM · Remarkup
btrahan awarded T8216: Make mailKey-related errors more obvious when testing new mail code a Doubloon token.
May 19 2015, 5:54 PM · Projects
epriestley added a revision to T8221: Firefox failed to display the embded image correctly (while chrome does mange it): Unknown Object (Differential Revision).
May 19 2015, 5:45 PM · Remarkup
epriestley added a comment to T8234: Dynamic Custom Field Support.

We are very unlikely to ever support this.

May 19 2015, 5:41 PM · Custom Fields
epriestley lowered the priority of T8234: Dynamic Custom Field Support from Normal to Wishlist.
May 19 2015, 5:41 PM · Custom Fields
epriestley updated subscribers of T8234: Dynamic Custom Field Support.
May 19 2015, 5:41 PM · Custom Fields
epriestley merged task T8254: Cascaded custom input fields into T8234: Dynamic Custom Field Support.
May 19 2015, 5:41 PM · Custom Fields
epriestley created T8259: `arc diff` doesn't use chunked uploads.
May 19 2015, 5:04 PM · Arcanist
epriestley added a comment to T8241: phabricator.org says that Pholio is still in beta.

(I pushed this, too.)

May 19 2015, 4:03 PM · Public & Media Relations
epriestley added a comment to T8253: Upload file fails, probably my fault.

I haven't seen this one before. My guess is that it might be because you have display_startup_errors on, and possibly we should detect that and raise an issue for it, although it's sort of good to show these errors somehow.

May 19 2015, 4:02 PM · Files
epriestley closed T8257: Advice to help me making aphlict ipv6 compatible as Wontfix.

We aren't interested in supporting IPv6 in the upstream at this time, and don't have the time or resources to help you develop a patch.

May 19 2015, 3:51 PM · Aphlict
epriestley edited P1786 css-changes.
May 19 2015, 3:47 PM
epriestley added a comment to T8256: Allow global searching of repository names (instead of commits).

Type r and then part of a repository name, like:

May 19 2015, 2:14 PM · Restricted Project, Search
epriestley closed T8255: Project search: Exception "Cursor does not identify a valid object." when using non-digit "after" URL parameter as Wontfix.

This behavior is expected. Cursor values are not intended to be human-editable. The fact that this worked in previous versions was a side effect of how the cursor was implemented at the time, and not an intentional feature.

May 19 2015, 1:24 PM · Projects
epriestley updated subscribers of T8252: Maniphest number parsing in blog generates a core:edge exception.

See also T6403 for a longer-term fix for this.

May 19 2015, 1:22 PM · Phame
epriestley renamed Changelog from Changelog - Ivorie to Changelog.
May 19 2015, 12:55 PM

May 18 2015

cburroughs awarded T8236: `arc weld` should do something a Manufacturing Defect? token.
May 18 2015, 11:02 PM · Contributor Onboarding, Arcanist
epriestley added a comment to T8230: Getting Paste/Feed error in Project Feed.

Let me know if that didn't fix it ^^

May 18 2015, 8:59 PM · Feed, Projects
epriestley closed T8230: Getting Paste/Feed error in Project Feed as Resolved by committing Restricted Diffusion Commit.
May 18 2015, 8:57 PM · Feed, Projects
epriestley closed T8246: Workboards with durable column open should give it more space on the right as Resolved by committing Restricted Diffusion Commit.
May 18 2015, 7:51 PM · PHUI
epriestley added a revision to T8230: Getting Paste/Feed error in Project Feed: Unknown Object (Differential Revision).
May 18 2015, 7:50 PM · Feed, Projects
epriestley closed T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error. as Resolved by committing Restricted Diffusion Commit.
May 18 2015, 7:29 PM · Projects
epriestley added a revision to T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error.: Unknown Object (Differential Revision).
May 18 2015, 7:28 PM · Projects
epriestley claimed T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error..
May 18 2015, 7:25 PM · Projects
epriestley claimed T8246: Workboards with durable column open should give it more space on the right.
May 18 2015, 7:24 PM · PHUI
epriestley added a revision to T8246: Workboards with durable column open should give it more space on the right: Unknown Object (Differential Revision).
May 18 2015, 7:24 PM · PHUI
epriestley closed T8182: Calendar preview has timeline lines going through it as Resolved by committing Restricted Diffusion Commit.
May 18 2015, 7:18 PM · Calendar
epriestley closed T8182: Calendar preview has timeline lines going through it, a subtask of T7925: Calendar v1 Errata, as Resolved.
May 18 2015, 7:18 PM · Calendar
epriestley added a revision to T8182: Calendar preview has timeline lines going through it: Unknown Object (Differential Revision).
May 18 2015, 7:12 PM · Calendar
epriestley closed T8183: Remove "Away" and "Sporadic" statuses. as Resolved.

I think this is something we'll probably revisit in the long run but it's probably a v2+ type of thing and I'd expect it to be informed by other product decisions between now and then (and possibly by application changes like having meaningful automatic escalation).

May 18 2015, 7:04 PM · Calendar