Page MenuHomePhabricator

Error thrown when opening a file in Diffusion's file browser
Closed, ResolvedPublic

Description

Running rPa04af2a9eeee8269656bdaf61119cccace3a4ebd we get an error when opening a file in Diffusion's file browser. This seems to happen with any file we open in the file browser. The contents of the file and its history are loading and showing fine on that page, though.

Error:
array_fill_keys() expects parameter 1 to be array, null given at [DiffusionBrowseFileController.php:275]

Stack trace:

array_fill_keys called at [/opt/phabricator/src/applications/diffusion/controller/DiffusionBrowseFileController.php:275]
DiffusionBrowseFileController::buildCorpus called at [/opt/phabricator/src/applications/diffusion/controller/DiffusionBrowseFileController.php:94]
DiffusionBrowseFileController::processDiffusionRequest called at [/opt/phabricator/src/applications/diffusion/controller/DiffusionController.php:51]
DiffusionController::handleRequest called at [/opt/phabricator/src/aphront/AphrontController.php:69]
AphrontController::delegateToController called at [/opt/phabricator/src/applications/diffusion/controller/DiffusionBrowseMainController.php:36]
DiffusionBrowseMainController::processDiffusionRequest called at [/opt/phabricator/src/applications/diffusion/controller/DiffusionController.php:51]
DiffusionController::handleRequest called at [/opt/phabricator/src/aphront/configuration/AphrontApplicationConfiguration.php:226]
AphrontApplicationConfiguration::processRequest called at [/opt/phabricator/src/aphront/configuration/AphrontApplicationConfiguration.php:140]
AphrontApplicationConfiguration::runHTTPRequest called at [/opt/phabricator/webroot/index.php:19]

Revisions and Commits

Restricted Differential Revision

Event Timeline

marceldegraaf raised the priority of this task from to Needs Triage.
marceldegraaf updated the task description. (Show Details)
marceldegraaf added a project: Diffusion.
marceldegraaf added a subscriber: marceldegraaf.

Addition: the error disappears when we disable syntax highlighting in the file browser.

epriestley triaged this task as Normal priority.
epriestley added a revision: Restricted Differential Revision.May 21 2015, 2:30 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.May 21 2015, 4:28 PM
epriestley added a commit: Restricted Diffusion Commit.

Thanks @epriestley, just deployed this and can confirm that it's fixed.