Page MenuHomePhabricator
Create Task
Maniphest T8259

`arc diff` doesn't use chunked uploads
Closed, ResolvedPublic
Actions

Description

Adding or removing very large (>4MB) binaries doesn't use chunk-aware uploads. It should use the same chunk-aware upload code that arc upload uses.

Revisions and Commits

rARC Arcanist
D13038rARCa36dc81715f6 Provide more documentation for Arcanist upload stuff
D13017rARC5c7b22e620f8 Use file.allocate to upload large files from `arc diff`
D13016rARC877e7b63884d Move Conduit file upload logic into a separate class

Related Objects

Event Timeline

epriestley created this task.May 19 2015, 5:04 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Arcanist.
epriestley added a subscriber: epriestley.
nickz added a subscriber: nickz.May 19 2015, 5:09 PM
joshuaspence added a subscriber: joshuaspence.May 19 2015, 8:33 PM
epriestley added a revision: D13016: Move Conduit file upload logic into a separate class.May 26 2015, 3:18 PM
epriestley added a revision: D13017: Use file.allocate to upload large files from `arc diff`.May 26 2015, 3:57 PM
joshuaspence mentioned this in T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user.May 27 2015, 11:01 AM
epriestley added a revision: D13038: Provide more documentation for Arcanist upload stuff.May 27 2015, 5:18 PM
epriestley closed this task as Resolved by committing rARC5c7b22e620f8: Use file.allocate to upload large files from `arc diff`.May 27 2015, 5:25 PM
epriestley added a commit: rARC877e7b63884d: Move Conduit file upload logic into a separate class.
epriestley added a commit: rARC5c7b22e620f8: Use file.allocate to upload large files from `arc diff`.
epriestley added a commit: rARCa36dc81715f6: Provide more documentation for Arcanist upload stuff.
Phabricator · Built by Phacility