Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F14862546: D20374.id48640.diff
Fri, Feb 7, 6:11 PM
Unknown Object (File)
Fri, Jan 31, 3:55 PM
Unknown Object (File)
Tue, Jan 28, 5:07 AM
Unknown Object (File)
Tue, Jan 28, 5:07 AM
Unknown Object (File)
Tue, Jan 28, 5:07 AM
Unknown Object (File)
Sat, Jan 25, 4:27 PM
Unknown Object (File)
Sat, Jan 25, 4:36 AM
Unknown Object (File)
Sat, Jan 25, 4:36 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Branch
portal21
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22473
Build 30769: Run Core Tests
Build 30768: arc lint + arc unit