Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F19937322: D20374.diff
Sun, Apr 12, 9:30 PM
F19880899: D20374.diff
Wed, Mar 18, 9:03 PM
F19855184: D20374.diff
Mar 13 2026, 1:08 PM
F19814355: D20374.diff
Mar 4 2026, 1:50 PM
F19617348: D20374.diff
Feb 4 2026, 6:00 AM
F19596862: D20374.id48599.diff
Feb 2 2026, 8:37 PM
F19510275: D20374.diff
Jan 11 2026, 6:53 AM
F19444955: D20374.id48640.diff
Dec 29 2025, 9:47 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable