Page MenuHomePhabricator

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
ClosedPublic

Authored by epriestley on Apr 2 2019, 6:59 PM.
Tags
None
Referenced Files
F14042610: D20372.diff
Tue, Nov 12, 4:47 AM
F14027705: D20372.diff
Fri, Nov 8, 8:55 AM
F13963752: D20372.id48638.diff
Tue, Oct 15, 5:42 PM
Unknown Object (File)
Oct 13 2024, 5:50 AM
Unknown Object (File)
Oct 9 2024, 12:00 PM
Unknown Object (File)
Oct 5 2024, 9:46 PM
Unknown Object (File)
Sep 19 2024, 1:26 AM
Unknown Object (File)
Sep 9 2024, 3:27 PM
Subscribers
None

Details

Summary

Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan

Created and edited a "text" panel.