Page MenuHomePhabricator

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
ClosedPublic

Authored by epriestley on Apr 2 2019, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:28 PM
Unknown Object (File)
Sun, Mar 10, 5:27 AM
Unknown Object (File)
Feb 3 2024, 9:59 PM
Unknown Object (File)
Jan 30 2024, 4:50 PM
Unknown Object (File)
Dec 20 2023, 11:34 AM
Unknown Object (File)
Dec 15 2023, 11:36 AM
Unknown Object (File)
Dec 8 2023, 6:11 PM
Unknown Object (File)
Dec 5 2023, 3:05 PM
Subscribers
None

Details

Summary

Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan

Created and edited a "text" panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable