Paths

Table of Contentst

Differential D20371

Mostly replace the old panel "Edit" controller with the new "Editpro" controller
ClosedPublic
Actions

Authored by epriestley on Apr 2 2019, 6:00 PM.

Tags

None

Referenced Files

	F15533400: D20371.id48637.diff
	Wed, Apr 23, 7:25 PM

	F15497237: D20371.id48637.diff
	Sun, Apr 13, 10:06 AM

	F15495537: D20371.id.diff
	Sun, Apr 13, 4:48 AM

	F15495235: D20371.id48596.diff
	Sun, Apr 13, 3:25 AM

	F15492507: D20371.id48596.diff
	Sat, Apr 12, 3:15 PM

	F15490257: D20371.diff
	Fri, Apr 11, 3:44 PM

	F15471367: D20371.diff
	Sat, Apr 5, 4:41 AM

	F15380826: D20371.id48637.diff
	Mar 14 2025, 4:39 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP68d969094ffb: Mostly replace the old panel "Edit" controller with the new "Editpro" controller

Summary

Depends on D20370. Ref T13272. This tries to get panel editing fully on the newer "Modular Transactions" + "EditEngine" flow.

This breaks tab panels a bit, but I'll fix that in a followup. And they weren't exactly in great shape before.

Also makes the flow prettier. :3

Test Plan

Screen Shot 2019-04-02 at 10.38.19 AM.png (422×916 px, 42 KB)

Diff Detail

Repository

Branch

portal18

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22470
Build 30763: Run Core Tests
Build 30762: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 2 2019, 6:00 PM

Harbormaster completed remote builds in B22470: Diff 48596.Apr 2 2019, 6:02 PM

epriestley requested review of this revision.Apr 2 2019, 6:02 PM

epriestley added inline comments.Apr 2 2019, 6:05 PM

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php
1	The actual diff is a mess here, but basically I deleted `EditController` (old), moved `EditproController` (new) on top of it, and then fixed up the "Create a Panel Directly on a Dashboard" flow. You can sort of ignore the left side of the diff in this file.

epriestley added a child revision: D20372: Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior.Apr 2 2019, 6:59 PM

amckinley accepted this revision.Apr 3 2019, 7:04 PM

This revision is now accepted and ready to land.Apr 3 2019, 7:04 PM

epriestley mentioned this in D20369: Move Dashboard panel controllers into a "panel/" subdirectory.Apr 4 2019, 2:46 PM

Closed by commit rP68d969094ffb: Mostly replace the old panel "Edit" controller with the new "Editpro" controller (authored by epriestley). · Explain WhyApr 9 2019, 8:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

dashboard/

application/

PhabricatorDashboardApplication.php

6 lines

controller/

panel/

PhabricatorDashboardPanelEditController.php

381 lines

PhabricatorDashboardPanelEditproController.php

PhabricatorDashboardPanelListController.php

4 lines

editor/

PhabricatorDashboardPanelEditEngine.php

54 lines

engine/

PhabricatorDashboardRenderingEngine.php

6 lines

paneltype/

PhabricatorDashboardTabsPanelType.php

2 lines

PhabricatorDashboardTextPanelType.php

6 lines

Diff 48596

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/application/PhabricatorDashboardApplication.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditproController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelListController.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php

Loading...