Details
- Reviewers
amckinley - Maniphest Tasks
- T13272: Remove the hard-coded homepage, and other Dashboards improvements
- Commits
- rP81b58dba8f73: Modularize Dashboard Panel transactionns
Created and edited panels. This will get vetted more thoroughly after additional changes.
Diff Detail
- Repository
- rP Phabricator
- Branch
- portal17
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 22469 Build 30761: Run Core Tests Build 30760: arc lint + arc unit
Event Timeline
| src/applications/dashboard/xaction/panel/PhabricatorDashboardPanelNameTransaction.php | ||
|---|---|---|
| 63–68 | Isn't this the default implementation for ModularTransactions? | |
| src/applications/dashboard/xaction/panel/PhabricatorDashboardPanelNameTransaction.php | ||
|---|---|---|
| 63–68 | By default, we don't expose anything to Conduit. Some transactions have complex/weird/sensitive/not-good-for-API-users details, and if we exposed them by default we might end up in trouble (maybe users trying to use them and complaining that they're impossible to work with; maybe users complaining that we broke compatibility if we then fix it; maybe actual security problems), so we err on the side of caution and require each transaction have an explicit implementation. In this case (and other simple cases) there's an obviously reasonable way to represent the transaction, but I just delete / don't implement these methods a lot of the time if there's any ambiguity. Usually, this only impacts webhooks trying to do something with the event. | |