Page MenuHomePhabricator

HeraldProject
ActivePublic

Details

Description

Watch for danger.

Recent Activity

Sep 10 2018

GoogleLegacy added a comment to T7804: Implement an "Acting User" Herald condition.
Sep 10 2018, 9:06 AM · Restricted Project, Herald, Mail
GoogleLegacy added a comment to T8726: Modularize Herald fields and actions.
Sep 10 2018, 9:06 AM · Herald
GoogleLegacy added a comment to T9054: Undefined class constant ACTION_BLOCK.
Sep 10 2018, 9:05 AM · Herald

Aug 30 2018

aristedes added a comment to T6491: Herald rules based on age.

With D11419 implemented, is it possible to now allow Herald rules to be triggered on a cron (even a very simple 'daily' option would be good)?

Aug 30 2018, 12:18 AM · Restricted Project, Herald

Aug 13 2018

epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

The root use case here was a desire for a better sense of how often certain rules were firing, and we improved the push logs instead to address this more directly (D19555, D19556, D19557).

Aug 13 2018, 4:53 PM · Diffusion, Herald

Aug 2 2018

epriestley added a comment to T920: Provide SMS Support.

On SMS MFA, Reddit got bitten recently by SMS having poor security properties:

Aug 2 2018, 11:29 PM · Restricted Project, Herald

Jul 17 2018

epriestley lowered the priority of T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Normal to Wishlist.

I'm going to look at improving the push logs a bit to show which rule blocked a push to address the actual use case in PHI765, which makes this more of a distance nice-to-have.

Jul 17 2018, 5:15 PM · Diffusion, Herald
epriestley triaged T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive as Normal priority.
Jul 17 2018, 4:56 PM · Diffusion, Herald

Jul 16 2018

jasonrumney added a comment to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'.

I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:

Jul 16 2018, 2:18 PM · Restricted Project, Herald

Apr 25 2018

epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See PHI612 and elsewhere; using "Take action [the first time this rule matches]" isn't always obvious but is usually a better fit than "When [ thing is created ]" and interacts much better with drafts.

Apr 25 2018, 4:48 PM · Restricted Project, Herald

Mar 29 2018

epriestley added a commit to T8951: Allow Diffusion repositories to disable Herald Rules: rP74216ea8e008: Disable Herald and enormous change protection for repository initial imports.
Mar 29 2018, 3:05 PM · Restricted Project, Diffusion, Herald
epriestley added a revision to T8951: Allow Diffusion repositories to disable Herald Rules: D19265: Disable Herald and enormous change protection for repository initial imports.
Mar 29 2018, 2:22 PM · Restricted Project, Diffusion, Herald

Feb 27 2018

bcooksley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

Okay. For the sake of 100% clarity it would be nice if the timeline story did show why the action was taken as it isn't immediately clear (unless you've read the documentation of course) why it was removed.

Feb 27 2018, 8:05 AM · Herald, Diffusion, Projects

Feb 26 2018

epriestley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

I'll make a note on T12455, but we might be able to render this timeline story more clearly, e.g. "X added project Y (which automatically removed Z, a subproject)" but I think this is likely fairly natural/obvious in most cases and I'm not sure if it's trivial to completely explain in the timeline.

Feb 26 2018, 6:16 PM · Herald, Diffusion, Projects
bcooksley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

Ah, that would certainly explain it. Sorry for the noise - when entering this I did wonder if I had missed something as it didn't make sense that a name collision would be able to cause this.

Feb 26 2018, 6:02 PM · Herald, Diffusion, Projects
epriestley closed T13092: Diffusion tagging can't handle projects with similar names as Resolved.

"Plasma on Wayland" is a subproject of "Plasma".

Feb 26 2018, 3:17 PM · Herald, Diffusion, Projects
bcooksley created T13092: Diffusion tagging can't handle projects with similar names.
Feb 26 2018, 9:04 AM · Herald, Diffusion, Projects

Feb 12 2018

epriestley added a comment to T8951: Allow Diffusion repositories to disable Herald Rules.

Sorry, the only way to influence feature development is through a support pact. See also Planning.

Feb 12 2018, 4:48 PM · Restricted Project, Diffusion, Herald
siepkes added a comment to T8951: Allow Diffusion repositories to disable Herald Rules.

@epriestley Would you guys be open for a patch for this? How would you like to see this implemented in order to be acceptable for you guys?

Feb 12 2018, 9:21 AM · Restricted Project, Diffusion, Herald

Feb 10 2018

epriestley moved T13041: In Herald Commit rules, "Commit Fields > Reviewer" has ancient, misleading behavior from Backlog to Far Future Work on the Differential board.
Feb 10 2018, 7:40 PM · Diffusion, Differential, Herald

Feb 9 2018

epriestley updated the task description for T5462: How do I publish Phabricator events into remote systems?.
Feb 9 2018, 11:05 PM · Guides, Doorkeeper, Feed, Herald
epriestley closed T11330: Allow Herald to "Queue Call to Webhook: ...", a subtask of T5462: How do I publish Phabricator events into remote systems?, as Resolved.
Feb 9 2018, 9:57 PM · Guides, Doorkeeper, Feed, Herald

Feb 8 2018

epriestley closed T7804: Implement an "Acting User" Herald condition as Resolved by committing rPbca9c08953bd: Add an "Acting user" field to Herald.
Feb 8 2018, 5:52 PM · Restricted Project, Herald, Mail
epriestley added a revision to T7804: Implement an "Acting User" Herald condition: D19031: Add an "Acting user" field to Herald.
Feb 8 2018, 5:41 PM · Restricted Project, Herald, Mail
epriestley moved T7804: Implement an "Acting User" Herald condition from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:40 PM · Restricted Project, Herald, Mail

Feb 6 2018

epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP4c14dd1e8925: (stable) Fix a Herald repetition policy selection error for rule types which….
Feb 6 2018, 5:49 PM · Herald

Feb 5 2018

epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rPef121b3e17cf: Fix a Herald repetition policy selection error for rule types which support….
Feb 5 2018, 9:35 PM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18992: Fix a Herald repetition policy selection error for rule types which support only one policy.
Feb 5 2018, 2:05 PM · Herald

Jan 29 2018

epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rPd8f51dff6ec3: Use the configured viewer more consistently in the Herald commit adapter.
Jan 29 2018, 11:00 PM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18950: Use the configured viewer more consistently in the Herald commit adapter.
Jan 29 2018, 1:54 AM · Herald

Jan 26 2018

epriestley closed T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald as Resolved.
Jan 26 2018, 11:29 PM · Herald
epriestley closed T11112: Herald allows setting multiple values in fields that should only accept one value as Resolved by committing rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set….
Jan 26 2018, 9:23 PM · Herald, Bug Report
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set….
Jan 26 2018, 9:23 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP5058cfb9726f: Pass a real viewer to HeraldAdapter when doing test console runs.
Jan 26 2018, 7:08 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rPa9f87857af4b: Mark the "Reviewer" field for Commits as deprecated.
Jan 26 2018, 7:07 PM · Herald
epriestley added a commit to T13041: In Herald Commit rules, "Commit Fields > Reviewer" has ancient, misleading behavior: rPa9f87857af4b: Mark the "Reviewer" field for Commits as deprecated.
Jan 26 2018, 7:07 PM · Diffusion, Differential, Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP5c762d895796: Document the new "only if this didn't match last time" Herald action setting.
Jan 26 2018, 7:06 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rPa34b6bdd06b7: Implement an "only if the rule did not match last time" policy for Herald rules.
Jan 26 2018, 7:06 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP204d1de68376: Convert storage for Herald repetition policy to "text32".
Jan 26 2018, 7:05 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP1dd1237c9228: Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule.
Jan 26 2018, 7:03 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rPa90b16e83a33: Define available Herald rule repetition options in terms of….
Jan 26 2018, 7:02 PM · Herald
epriestley added a commit to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: rP042c43d6d843: Remove a very old Herald garbage collection migration.
Jan 26 2018, 6:54 PM · Herald
epriestley moved T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald from Backlog to Next on the Herald board.
Jan 26 2018, 5:53 PM · Herald
epriestley moved T11112: Herald allows setting multiple values in fields that should only accept one value from Backlog to Next on the Herald board.
Jan 26 2018, 5:53 PM · Herald, Bug Report
epriestley moved T8644: Herald template / recipe book / examples / quick-create tool from Future to Guidance on the Herald board.
Jan 26 2018, 5:53 PM · Restricted Project, Herald
epriestley moved T11566: Provide more complete guidance on using regular expressions in Herald from Backlog to Guidance on the Herald board.
Jan 26 2018, 5:53 PM · Herald, Documentation
epriestley moved T13039: Support numeric fields in Herald from Backlog to Far Future on the Herald board.
Jan 26 2018, 5:52 PM · Herald
epriestley moved T4971: Add support for "Added filenames" and "Removed filenames" in Herald from Backlog to Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Herald
epriestley moved T8644: Herald template / recipe book / examples / quick-create tool from Backlog to Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Herald
epriestley moved T7804: Implement an "Acting User" Herald condition from Next to Far Future on the Herald board.
Jan 26 2018, 5:52 PM · Restricted Project, Herald, Mail