Page MenuHomePhabricator

HeraldProject
ActivePublic

Details

Description

Watch for danger.

Recent Activity

Mon, Feb 3

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.
Mon, Feb 3, 1:05 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

See https://discourse.phabricator-community.org/t/herald-rule-not-adding-auditors-to-commits-following-upgrade/3505 for one bug with this.

Mon, Feb 3, 1:04 PM · Projects, Owners, Herald

Wed, Jan 29

epriestley closed T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Resolved by committing rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and….
Wed, Jan 29, 11:52 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks.
Wed, Jan 29, 10:56 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20956: Update Herald rule creation workflow to use more modern UI elements.
Wed, Jan 29, 8:40 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20955: In Herald "Commit" rules, use repository identities to identify authors and committers.
Wed, Jan 29, 6:40 PM · Projects, Owners, Herald

Jan 24 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Jan 24 2020, 1:16 AM · Projects, Owners, Herald

Jan 23 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20951: In Herald transcripts, render some field values in a more readable way.
Jan 23 2020, 11:38 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20949: In Herald transcript rendering, don't store display labels in keys.
Jan 23 2020, 7:51 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20948: Remove legacy pre-loading of handles from Herald rendering.
Jan 23 2020, 7:42 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

Remaining work:

Jan 23 2020, 2:43 AM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

D20947 does not implement "Author's packages" as a "Commit Content" field, nor as a "Commit Content (Hook)" field. The reason for this is that getting the modern authorPHID in both cases is somewhat complicated.

Jan 23 2020, 2:20 AM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20947: Implement an "Author's packages" Herald field for Differential.
Jan 23 2020, 2:17 AM · Projects, Owners, Herald

Jan 21 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Jan 21 2020, 7:31 PM · Projects, Owners, Herald

Jan 17 2020

epriestley triaged T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Wishlist priority.
Jan 17 2020, 5:05 PM · Projects, Owners, Herald

Jan 15 2020

epriestley added a comment to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.

This should be fixed by D20943. Note that "Mute" in this context mutes notifications about edits to the object (e.g. "Alice renamed rule Hxxx from X to Y."), not notifications sent by the rule itself.

Jan 15 2020, 4:31 PM · Herald
epriestley closed T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Resolved by committing rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Jan 15 2020, 4:29 PM · Herald
epriestley added a revision to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`: D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Jan 15 2020, 4:27 PM · Herald
epriestley triaged T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Wishlist priority.
Jan 15 2020, 4:23 PM · Herald

Nov 6 2019

epriestley closed T13445: Improve clarity of "do not include" condition in Herald as Resolved by committing rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:55 PM · Herald
epriestley updated the task description for T13445: Improve clarity of "do not include" condition in Herald.
Nov 6 2019, 3:53 PM · Herald
epriestley added a revision to T13445: Improve clarity of "do not include" condition in Herald: D20889: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:53 PM · Herald
epriestley triaged T13445: Improve clarity of "do not include" condition in Herald as Low priority.
Nov 6 2019, 3:51 PM · Herald

Sep 25 2019

epriestley added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I've moved the issue in PHI1264 (roughly, "commenting on an unpublished commit should still work normally") here from T13284, since it ended up not really fitting into that scope particularly well.

Sep 25 2019, 4:01 PM · Diffusion, Herald
epriestley updated the task description for T13299: Herald only triggers for commits once, during the initial publish phase.
Sep 25 2019, 4:00 PM · Diffusion, Herald

Sep 12 2019

epriestley closed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Resolved.

D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.

Sep 12 2019, 7:59 PM · Applications, Herald
epriestley added a revision to T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them.
Sep 12 2019, 7:57 PM · Applications, Herald

Sep 11 2019

mormegil added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I understand this was supposed to be mentioned here: Herald ignores commits that are ancestors of permanent refs if they were previously pushed to some other non-permanent ref.

Sep 11 2019, 9:10 AM · Diffusion, Herald

Sep 9 2019

epriestley closed T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule' as Resolved by committing rP1d1a60fdda88: Improve rendering of Herald rules in "Another Herald rule..." field.
Sep 9 2019, 8:29 PM · Restricted Project, Herald
epriestley added a revision to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule': D20798: Improve rendering of Herald rules in "Another Herald rule..." field.
Sep 9 2019, 8:25 PM · Restricted Project, Herald
epriestley closed T8952: Hide "Herald added subscribers..." stories from feed completely as Resolved by committing rP7593a265d593: When Herald changes object subscribers, always hide the feed story.
Sep 9 2019, 8:17 PM · Feed, Herald
epriestley closed T13409: Support a "Remove Flag" action in Herald as Resolved by committing rP454771446306: Add a "Remove flag" action to Herald.
Sep 9 2019, 8:16 PM · Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

0.00000000001 is very funny and we would be losing a truly great joke at such a young age

Sep 9 2019, 8:15 PM · Feed, Herald
epriestley added a revision to T8952: Hide "Herald added subscribers..." stories from feed completely: D20797: When Herald changes object subscribers, always hide the feed story.
Sep 9 2019, 8:14 PM · Feed, Herald
epriestley added a revision to T13409: Support a "Remove Flag" action in Herald: D20796: Add a "Remove flag" action to Herald.
Sep 9 2019, 8:02 PM · Herald
epriestley closed T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Resolved by committing rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a….
Sep 9 2019, 7:50 PM · Herald
epriestley added a revision to T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects: D20795: Index Herald fields, not just actions, when identifying objects related to a particular Herald rule.
Sep 9 2019, 7:44 PM · Herald
epriestley triaged T13409: Support a "Remove Flag" action in Herald as Low priority.
Sep 9 2019, 2:35 PM · Herald
epriestley triaged T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Low priority.
Sep 9 2019, 2:33 PM · Herald

May 31 2019

epriestley added a revision to T13298: Improve Herald profiling information available in transcripts: D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
May 31 2019, 2:59 PM · Herald
epriestley added a revision to T13298: Improve Herald profiling information available in transcripts: D20566: Add a basic profiler to Herald transcripts.
May 31 2019, 2:33 PM · Herald

May 27 2019

epriestley moved T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Far Future to Next on the Herald board.
May 27 2019, 3:36 PM · Diffusion, Herald
epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

A sort of broad issue here is that Herald sometimes knows (or could know, or could guess, or maybe could speculate) that a rule won't do what you expect, but it doesn't tell you.

May 27 2019, 3:36 PM · Diffusion, Herald
epriestley triaged T13299: Herald only triggers for commits once, during the initial publish phase as Normal priority.
May 27 2019, 3:34 PM · Diffusion, Herald
epriestley closed T13283: When Herald acts, include the transaction group as part of the "state" it acts upon as Resolved.

I think this is about as good as we're going to get, and we've only taken a very small step toward the precipice of a self-aware Herald that hates humankind.

May 27 2019, 2:56 PM · Herald
epriestley triaged T13298: Improve Herald profiling information available in transcripts as Normal priority.
May 27 2019, 2:54 PM · Herald
epriestley closed T12257: Add an "author email" field to the "Differential Diff" Herald rule as Wontfix.

KDE appears to be moving to GitLab (see: https://gitlab.com/gitlab-org/gitlab-ce/issues/53206) and we haven't seen this request from other installs, so I'm just going to close this out.

May 27 2019, 2:38 PM · KDE, Herald, Differential
epriestley closed T8804: Replacing a Herald rule with a Doorkeeper extension as Wontfix.

I think the modern answer here is "use Webhooks". They may not do everything you want if you're writing a chat bot (notably, they intentionally do not currently provide a human-readable text representation of transactions) but there generally suitable for publishing changes to Phabricator objects into a remote system and will produce a program with generally reasonable behaviors and no weird demons lurking under the surface.

May 27 2019, 2:30 PM · Restricted Project, Herald, Doorkeeper

May 22 2019

epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: D20547: In the Herald test console, don't consider transactions that Herald rules applied.
May 22 2019, 9:48 PM · Herald
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
May 22 2019, 9:41 PM · Herald