Page MenuHomePhabricator

HeraldProject
ActivePublic

Details

Description

Watch for danger.

Recent Activity

Yesterday

epriestley added a revision to T920: Provide SMS Support: D19988: Add "Contact Numbers" so we can send users SMS mesages.
Thu, Jan 17, 3:48 PM · Restricted Project, Herald

Wed, Jan 16

epriestley added a commit to T920: Provide SMS Support: rP35f0e31ed3b2: Add a Twilio SMS message adapter.
Wed, Jan 16, 9:26 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rP96d3e73eed64: Fix an issue where "CC"-only email improperly wiped CC addresses.
Wed, Jan 16, 9:22 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPc3cafffed726: Update the "SES" and "sendmail" mailers for the new API; remove "encoding".
Wed, Jan 16, 9:19 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rP43a6f34e7f2b: Update the SMTP (PHPMailer) adapter for the new mail API; remove "encoding" and….
Wed, Jan 16, 9:11 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rP64e3296fe682: Upgrade Sendgrid to the modern mailer API; removes "api-user" option.
Wed, Jan 16, 9:09 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPd7da3560ec56: Update Mailgun adapter for the new mail adapter API.
Wed, Jan 16, 9:02 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPbc97a7d7556a: Update Mail test adapter for the newer adapter API and make all tests pass.
Wed, Jan 16, 9:01 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPa8657e6ab6fd: Update Postmark adapter for multiple mail media.
Wed, Jan 16, 9:00 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPb5797ce60a35: Refactor mail to produce an intermediate "bag of strings" object in preparation….
Wed, Jan 16, 8:58 PM · Restricted Project, Herald
amckinley added a revision to T920: Provide SMS Support: D19982: Add infrastructure for sending SMS via AWS SNS.
Wed, Jan 16, 7:09 PM · Restricted Project, Herald

Mon, Jan 14

epriestley added a revision to T920: Provide SMS Support: D19971: Add a Twilio SMS message adapter.
Mon, Jan 14, 9:55 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19970: Fix an issue where "CC"-only email improperly wiped CC addresses.
Mon, Jan 14, 9:33 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19965: Update the "SES" and "sendmail" mailers for the new API; remove "encoding".
Mon, Jan 14, 5:02 PM · Restricted Project, Herald
epriestley added a comment to T920: Provide SMS Support.

Currently, the SES adapter extends from the Sendmail (PHPMailerLite) adapter. I'd like to fix this.

Mon, Jan 14, 3:41 PM · Restricted Project, Herald

Sat, Jan 5

epriestley added a comment to T920: Provide SMS Support.

Currently, the SES adapter extends from the Sendmail (PHPMailerLite) adapter. I'd like to fix this.

Sat, Jan 5, 3:40 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19961: Update the SMTP (PHPMailer) adapter for the new mail API; remove "encoding" and "mailer".
Sat, Jan 5, 3:25 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19960: Upgrade Sendgrid to the modern mailer API; removes "api-user" option.
Sat, Jan 5, 2:32 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19959: Update Mailgun adapter for the new mail adapter API.
Sat, Jan 5, 12:59 PM · Restricted Project, Herald

Fri, Jan 4

epriestley added a commit to T920: Provide SMS Support: rPe2f057110462: Drop empty inbound mail at the beginning of the receive workflow, not inside….
Fri, Jan 4, 9:50 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPa0668df75a2d: Remove "metamta.domain" and "metamta.placeholder-to-recipient" config options.
Fri, Jan 4, 9:45 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rP7e87d254ab33: Add a parameterized Future for Twilio API calls.
Fri, Jan 4, 9:43 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19957: Update Mail test adapter for the newer adapter API and make all tests pass.
Fri, Jan 4, 8:59 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19956: Update Postmark adapter for multiple mail media.
Fri, Jan 4, 8:09 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19955: Refactor mail to produce an intermediate "bag of strings" object in preparation for SMS.
Fri, Jan 4, 6:06 PM · Restricted Project, Herald

Thu, Jan 3

epriestley added a revision to T920: Provide SMS Support: D19947: Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers.
Thu, Jan 3, 2:28 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rP9d5b933ed5a3: Remove all legacy configuration options for mailers.
Thu, Jan 3, 12:09 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPcfcd35d8a390: Remove standalone SMS support in favor of a "Mail, SMS, and other media are….
Thu, Jan 3, 12:05 PM · Restricted Project, Herald
epriestley added a commit to T920: Provide SMS Support: rPe856e791f3ee: Remove Twilio-PHP API external.
Thu, Jan 3, 12:04 PM · Restricted Project, Herald

Wed, Jan 2

epriestley added a commit to T920: Provide SMS Support: rPea8be11addd7: Fix a qsprintf() issue in mail queries.
Wed, Jan 2, 10:39 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19942: Remove "metamta.domain" and "metamta.placeholder-to-recipient" config options.
Wed, Jan 2, 2:07 PM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19940: Remove all legacy configuration options for mailers.
Wed, Jan 2, 4:24 AM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19939: Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach.
Wed, Jan 2, 4:03 AM · Restricted Project, Herald
epriestley added a comment to T920: Provide SMS Support.

As tends to be par for the course, this is turning into a bit of a rabbit hole.

Wed, Jan 2, 3:56 AM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19938: Remove Twilio-PHP API external.
Wed, Jan 2, 3:16 AM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: D19937: Add a parameterized Future for Twilio API calls.
Wed, Jan 2, 3:12 AM · Restricted Project, Herald

Sun, Dec 30

epriestley added a revision to T920: Provide SMS Support: D19936: Fix a qsprintf() issue in mail queries.
Sun, Dec 30, 6:57 PM · Restricted Project, Herald
epriestley added a comment to T920: Provide SMS Support.

I'm considering pushing this forward since MFA is getting an update (see T13231 and adjacent tasks).

Sun, Dec 30, 6:53 PM · Restricted Project, Herald

Sep 10 2018

GoogleLegacy added a comment to T7804: Implement an "Acting User" Herald condition.
Sep 10 2018, 9:06 AM · Restricted Project, Herald, Mail
GoogleLegacy added a comment to T8726: Modularize Herald fields and actions.
Sep 10 2018, 9:06 AM · Herald
GoogleLegacy added a comment to T9054: Undefined class constant ACTION_BLOCK.
Sep 10 2018, 9:05 AM · Herald

Aug 30 2018

aristedes added a comment to T6491: Herald rules based on age.

With D11419 implemented, is it possible to now allow Herald rules to be triggered on a cron (even a very simple 'daily' option would be good)?

Aug 30 2018, 12:18 AM · Restricted Project, Herald

Aug 13 2018

epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

The root use case here was a desire for a better sense of how often certain rules were firing, and we improved the push logs instead to address this more directly (D19555, D19556, D19557).

Aug 13 2018, 4:53 PM · Diffusion, Herald

Aug 2 2018

epriestley added a comment to T920: Provide SMS Support.

On SMS MFA, Reddit got bitten recently by SMS having poor security properties:

Aug 2 2018, 11:29 PM · Restricted Project, Herald

Jul 17 2018

epriestley lowered the priority of T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Normal to Wishlist.

I'm going to look at improving the push logs a bit to show which rule blocked a push to address the actual use case in PHI765, which makes this more of a distance nice-to-have.

Jul 17 2018, 5:15 PM · Diffusion, Herald
epriestley triaged T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive as Normal priority.
Jul 17 2018, 4:56 PM · Diffusion, Herald

Jul 16 2018

jasonrumney added a comment to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'.

I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:

Jul 16 2018, 2:18 PM · Restricted Project, Herald

Apr 25 2018

epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See PHI612 and elsewhere; using "Take action [the first time this rule matches]" isn't always obvious but is usually a better fit than "When [ thing is created ]" and interacts much better with drafts.

Apr 25 2018, 4:48 PM · Restricted Project, Herald

Mar 29 2018

epriestley added a commit to T8951: Allow Diffusion repositories to disable Herald Rules: rP74216ea8e008: Disable Herald and enormous change protection for repository initial imports.
Mar 29 2018, 3:05 PM · Restricted Project, Diffusion, Herald
epriestley added a revision to T8951: Allow Diffusion repositories to disable Herald Rules: D19265: Disable Herald and enormous change protection for repository initial imports.
Mar 29 2018, 2:22 PM · Restricted Project, Diffusion, Herald