Page MenuHomePhabricator

HeraldProject
ActivePublic

Details

Description

Watch for danger.

Recent Activity

Mar 4 2021

epriestley added a comment to T13612: Support Herald rules for Harbormaster Builds.

I dug up another one of these in PHI1439, but there is a lot of text in that issue that I haven't re-read yet.

Mar 4 2021, 5:54 PM · Herald, Harbormaster

Feb 19 2021

epriestley added a comment to T13612: Support Herald rules for Harbormaster Builds.

A minimal implementation here is probably:

Feb 19 2021, 4:57 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:47 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:34 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:31 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:23 AM · Herald, Harbormaster
epriestley triaged T13612: Support Herald rules for Harbormaster Builds as Normal priority.
Feb 19 2021, 4:22 AM · Herald, Harbormaster

Feb 18 2021

epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21567: Apply "pcre.*_limit" ini options in web environments.
Feb 18 2021, 7:21 PM · Herald
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21566: Apply "pcre.*_limit" config options at startup in CLI environments.
Feb 18 2021, 7:17 PM · Herald
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21565: Provide a more structured result log for Herald rules.
Feb 18 2021, 6:53 PM · Herald
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21564: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult".
Feb 18 2021, 5:42 PM · Herald

Feb 17 2021

epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21563: Provide a more structured result log for Herald conditions.
Feb 17 2021, 9:48 PM · Herald
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Feb 17 2021, 9:37 PM · Herald

Feb 5 2021

epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See also PHI1987, which is another motivation for the "diffs with no revision" rule from T12771.

Feb 5 2021, 4:30 PM · Restricted Project, Herald

Jan 26 2021

epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

It looks like the case in PHI1977 was actually a situation of attempting to trigger an audit by writing a Differential rule, so the Global/Personal stuff may still be worth fixing but has zero known cases of actual confusion in the wild. I'm less sure how the UI could be clarified around the Audit/Differential issue.

Jan 26 2021, 4:21 PM · Diffusion, Herald

Jan 20 2021

epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

See PHI1977 for a somewhat-similar issue: a user was (probably) looking for an action available only in Global Herald rules, and didn't realize available actions depend on rule scope.

Jan 20 2021, 8:45 PM · Diffusion, Herald

Nov 7 2020

epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21493: Separate Herald transcripts into several different views.
Nov 7 2020, 12:20 AM · Herald
epriestley triaged T13586: In Herald transcripts, surface exceptions encountered while evaluating fields as Low priority.
Nov 7 2020, 12:18 AM · Herald
epriestley closed T13298: Improve Herald profiling information available in transcripts as Resolved.

The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issues.

Nov 7 2020, 12:09 AM · Herald

Oct 16 2020

epriestley added a revision to T13583: Support reasonable guardrails against mismatched data retention policies in comment content: D21479: Add a "Comment content" field to Herald.
Oct 16 2020, 8:29 PM · Herald
epriestley triaged T13583: Support reasonable guardrails against mismatched data retention policies in comment content as Normal priority.
Oct 16 2020, 8:27 PM · Herald

May 20 2020

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D21281: Drop old "differential_commit" table.
May 20 2020, 7:30 PM · Diffusion, Harbormaster, Herald, Audit

Feb 3 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.
Feb 3 2020, 1:05 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

See https://discourse.phabricator-community.org/t/herald-rule-not-adding-auditors-to-commits-following-upgrade/3505 for one bug with this.

Feb 3 2020, 1:04 PM · Projects, Owners, Herald

Jan 29 2020

epriestley closed T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Resolved by committing rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and….
Jan 29 2020, 11:52 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks.
Jan 29 2020, 10:56 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20956: Update Herald rule creation workflow to use more modern UI elements.
Jan 29 2020, 8:40 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20955: In Herald "Commit" rules, use repository identities to identify authors and committers.
Jan 29 2020, 6:40 PM · Projects, Owners, Herald

Jan 24 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Jan 24 2020, 1:16 AM · Projects, Owners, Herald

Jan 23 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20951: In Herald transcripts, render some field values in a more readable way.
Jan 23 2020, 11:38 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20949: In Herald transcript rendering, don't store display labels in keys.
Jan 23 2020, 7:51 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20948: Remove legacy pre-loading of handles from Herald rendering.
Jan 23 2020, 7:42 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

Remaining work:

Jan 23 2020, 2:43 AM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

D20947 does not implement "Author's packages" as a "Commit Content" field, nor as a "Commit Content (Hook)" field. The reason for this is that getting the modern authorPHID in both cases is somewhat complicated.

Jan 23 2020, 2:20 AM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20947: Implement an "Author's packages" Herald field for Differential.
Jan 23 2020, 2:17 AM · Projects, Owners, Herald

Jan 21 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Jan 21 2020, 7:31 PM · Projects, Owners, Herald

Jan 17 2020

epriestley triaged T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Wishlist priority.
Jan 17 2020, 5:05 PM · Projects, Owners, Herald

Jan 15 2020

epriestley added a comment to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.

This should be fixed by D20943. Note that "Mute" in this context mutes notifications about edits to the object (e.g. "Alice renamed rule Hxxx from X to Y."), not notifications sent by the rule itself.

Jan 15 2020, 4:31 PM · Herald
epriestley closed T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Resolved by committing rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Jan 15 2020, 4:29 PM · Herald
epriestley added a revision to T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`: D20943: Allow the Herald Rule Editor to apply generic "Edge" transactions.
Jan 15 2020, 4:27 PM · Herald
epriestley triaged T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")` as Wishlist priority.
Jan 15 2020, 4:23 PM · Herald

Nov 6 2019

epriestley closed T13445: Improve clarity of "do not include" condition in Herald as Resolved by committing rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:55 PM · Herald
epriestley updated the task description for T13445: Improve clarity of "do not include" condition in Herald.
Nov 6 2019, 3:53 PM · Herald
epriestley added a revision to T13445: Improve clarity of "do not include" condition in Herald: D20889: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:53 PM · Herald
epriestley triaged T13445: Improve clarity of "do not include" condition in Herald as Low priority.
Nov 6 2019, 3:51 PM · Herald

Sep 25 2019

epriestley added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I've moved the issue in PHI1264 (roughly, "commenting on an unpublished commit should still work normally") here from T13284, since it ended up not really fitting into that scope particularly well.

Sep 25 2019, 4:01 PM · Diffusion, Herald
epriestley updated the task description for T13299: Herald only triggers for commits once, during the initial publish phase.
Sep 25 2019, 4:00 PM · Diffusion, Herald

Sep 12 2019

epriestley closed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Resolved.

D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.

Sep 12 2019, 7:59 PM · Applications, Herald
epriestley added a revision to T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them.
Sep 12 2019, 7:57 PM · Applications, Herald

Sep 11 2019

mormegil added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I understand this was supposed to be mentioned here: Herald ignores commits that are ancestors of permanent refs if they were previously pushed to some other non-permanent ref.

Sep 11 2019, 9:10 AM · Diffusion, Herald