Page MenuHomePhabricator

Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them

Authored by epriestley on Sep 12 2019, 7:57 PM.



Fixes T7961. Currently, we present Herald users with actions like "Require legalpad signatures" and "Run build plans" even if Legalpad and Harbormaster are not installed.

Instead, allow fields and actions to be made "unavailable", which means that we won't present them as options when adding to new or existing rules.

If you edit a rule which already uses one of these fields or actions, it isn't affected.

Test Plan
  • Created a rule with a legalpad action, uninstalled legalpad, edited the rule. Action remained untouched.
  • Created a new rule, wasn't offered the legalpad action.
  • Reinstalled the application, saw the action again.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 12 2019, 7:57 PM
Owners added a subscriber: Restricted Owners Package.Sep 12 2019, 7:57 PM
epriestley requested review of this revision.Sep 12 2019, 7:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 9:33 PM
This revision was automatically updated to reflect the committed changes.