Page MenuHomePhabricator

Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them
ClosedPublic

Authored by epriestley on Sep 12 2019, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 6, 4:31 AM
Unknown Object (File)
Fri, Jan 27, 11:42 PM
Unknown Object (File)
Thu, Jan 19, 7:58 AM
Unknown Object (File)
Fri, Jan 13, 1:22 PM
Unknown Object (File)
Dec 28 2022, 12:22 PM
Unknown Object (File)
Dec 27 2022, 11:52 AM
Unknown Object (File)
Dec 13 2022, 9:04 AM
Unknown Object (File)
Nov 22 2022, 4:54 PM
Subscribers
Restricted Owners Package

Details

Summary

Fixes T7961. Currently, we present Herald users with actions like "Require legalpad signatures" and "Run build plans" even if Legalpad and Harbormaster are not installed.

Instead, allow fields and actions to be made "unavailable", which means that we won't present them as options when adding to new or existing rules.

If you edit a rule which already uses one of these fields or actions, it isn't affected.

Test Plan
  • Created a rule with a legalpad action, uninstalled legalpad, edited the rule. Action remained untouched.
  • Created a new rule, wasn't offered the legalpad action.
  • Reinstalled the application, saw the action again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable