Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
F17948502: D21479.id51125.diff
Thu, Jul 31, 9:14 PM
F17948480: D21479.id51123.diff
Thu, Jul 31, 9:11 PM
F17935180: D21479.diff
Wed, Jul 30, 11:11 PM
F17756211: D21479.id51125.diff
Jul 22 2025, 1:52 PM
F17756210: D21479.id51123.diff
Jul 22 2025, 1:52 PM
F17756016: D21479.id.diff
Jul 22 2025, 1:32 PM
F17732047: D21479.diff
Jul 20 2025, 3:51 AM
Unknown Object (File)
Jul 2 2025, 7:35 PM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.