Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 1:48 AM
Unknown Object (File)
Mon, Nov 18, 3:24 AM
Unknown Object (File)
Sat, Nov 16, 9:01 PM
Unknown Object (File)
Thu, Nov 14, 8:59 PM
Unknown Object (File)
Sun, Nov 10, 9:58 AM
Unknown Object (File)
Wed, Nov 6, 10:01 AM
Unknown Object (File)
Oct 9 2024, 1:42 PM
Unknown Object (File)
Sep 28 2024, 3:16 PM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.