Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
F13089230: D21479.diff
Thu, Apr 25, 1:43 AM
Unknown Object (File)
Tue, Apr 23, 7:56 AM
Unknown Object (File)
Mar 20 2024, 8:07 PM
Unknown Object (File)
Mar 13 2024, 11:25 PM
Unknown Object (File)
Jan 23 2024, 12:11 PM
Unknown Object (File)
Jan 9 2024, 8:02 AM
Unknown Object (File)
Jan 7 2024, 4:42 AM
Unknown Object (File)
Dec 27 2023, 10:06 AM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.