Page MenuHomePhabricator

Change the Herald "do not include [any of]" condition label to "include none of"
ClosedPublic

Authored by epriestley on Wed, Nov 6, 3:53 PM.

Details

Summary

Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of".

Test Plan

Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Nov 6, 3:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Nov 6, 3:55 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.