Differential D20889

Change the Herald "do not include [any of]" condition label to "include none of"
ClosedPublic
Actions

Authored by epriestley on Nov 6 2019, 3:53 PM.

Tags

None

Referenced Files

	F14092567: D20889.diff
	Mon, Nov 25, 6:48 AM

	Unknown Object (File)
	Wed, Nov 20, 7:45 PM

	Unknown Object (File)
	Mon, Nov 18, 3:19 AM

	Unknown Object (File)
	Mon, Nov 18, 2:05 AM

	Unknown Object (File)
	Mon, Nov 18, 12:19 AM

	Unknown Object (File)
	Sun, Nov 17, 11:46 PM

	Unknown Object (File)
	Sun, Nov 17, 7:34 AM

	Unknown Object (File)
	Mon, Nov 11, 4:30 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13445: Improve clarity of "do not include" condition in Herald
Commits: rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of"

Summary

Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of".

Test Plan

Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 6 2019, 3:53 PM

Harbormaster completed remote builds in B23624: Diff 49794.Nov 6 2019, 3:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 3:55 PM

epriestley requested review of this revision.

Closed by commit rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of".

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

2 lines

Diff 49795

View Options

src/applications/herald/adapter/HeraldAdapter.php

Change the Herald "do not include [any of]" condition label to "include none of"ClosedPublicActions