Page MenuHomePhabricator

Change the Herald "do not include [any of]" condition label to "include none of"
ClosedPublic

Authored by epriestley on Nov 6 2019, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 12:33 AM
Unknown Object (File)
Feb 22 2024, 8:49 AM
Unknown Object (File)
Dec 30 2023, 10:16 PM
Unknown Object (File)
Dec 22 2023, 4:54 AM
Unknown Object (File)
Dec 18 2023, 3:36 PM
Unknown Object (File)
Dec 13 2023, 11:30 AM
Unknown Object (File)
Nov 30 2023, 12:45 AM
Unknown Object (File)
Nov 25 2023, 10:47 PM
Subscribers
None

Details

Summary

Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of".

Test Plan

Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 3:55 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.