Page MenuHomePhabricator

Provide a more structured result log for Herald conditions
ClosedPublic

Authored by epriestley on Feb 17 2021, 9:48 PM.
Tags
None
Referenced Files
F15460416: D21563.id51334.diff
Mon, Mar 31, 10:49 PM
F15458396: D21563.id51353.diff
Sun, Mar 30, 11:38 PM
F15448235: D21563.id.diff
Fri, Mar 28, 3:39 AM
F15444944: D21563.diff
Thu, Mar 27, 11:59 AM
F15426870: D21563.diff
Sun, Mar 23, 11:18 AM
F15423175: D21563.id.diff
Sat, Mar 22, 1:38 PM
F15422284: D21563.id51334.diff
Sat, Mar 22, 6:59 AM
F15422283: D21563.id51353.diff
Sat, Mar 22, 6:59 AM
Subscribers
None

Details

Summary

Ref T13586. Currently, Herald condition logs encode "pass" or "fail" robustly, "forbidden" through a sort of awkward side channel, and can not properly encode "invalid" or "exception" outcomes.

Structure the condition log so results are represented unambiguously and all possible outcomes (pass, fail, forbidden, invalid, exception) are clearly encoded.

Test Plan

Screen Shot 2021-02-17 at 1.30.55 PM.png (755×1 px, 173 KB)

Screen Shot 2021-02-17 at 1.35.55 PM.png (705×1 px, 142 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable