Page MenuHomePhabricator

Provide a more structured result log for Herald conditions
ClosedPublic

Authored by epriestley on Feb 17 2021, 9:48 PM.

Details

Summary

Ref T13586. Currently, Herald condition logs encode "pass" or "fail" robustly, "forbidden" through a sort of awkward side channel, and can not properly encode "invalid" or "exception" outcomes.

Structure the condition log so results are represented unambiguously and all possible outcomes (pass, fail, forbidden, invalid, exception) are clearly encoded.

Test Plan

Screen Shot 2021-02-17 at 1.30.55 PM.png (755×1 px, 173 KB)

Screen Shot 2021-02-17 at 1.35.55 PM.png (705×1 px, 142 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable