Differential D20943

Allow the Herald Rule Editor to apply generic "Edge" transactions
ClosedPublic
Actions

Authored by epriestley on Jan 15 2020, 4:27 PM.

Tags

None

Referenced Files

	F19487188: D20943.id49902.diff
	Thu, Jan 8, 4:07 AM

	F19479788: D20943.id49902.diff
	Wed, Jan 7, 10:04 PM

	F19465090: D20943.diff
	Sat, Jan 3, 3:01 AM

	F19083144: D20943.id49902.diff
	Dec 2 2025, 12:31 PM

	F19027326: D20943.id.diff
	Nov 24 2025, 1:40 PM

	F19016034: D20943.diff
	Nov 23 2025, 2:47 AM

	F18985310: D20943.id49901.diff
	Nov 17 2025, 12:58 PM

	F18857195: D20943.id.diff
	Nov 1 2025, 1:51 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`
Commits: rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions

Summary

Fixes T13469. Currently, "Mute" applies a generic edge transaction but the editor doesn't whitelist them.

Test Plan

Muted a Herald rule.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 15 2020, 4:27 PM

Harbormaster completed remote builds in B23727: Diff 49901.Jan 15 2020, 4:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2020, 4:29 PM

epriestley requested review of this revision.

Closed by commit rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.

epriestley mentioned this in T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.Jan 15 2020, 4:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

editor/

HeraldRuleEditor.php

6 lines

Diff 49902

View Options

src/applications/herald/editor/HeraldRuleEditor.php

Allow the Herald Rule Editor to apply generic "Edge" transactionsClosedPublicActions