Page MenuHomePhabricator

Lift core of "HeraldConditionResult" to "HeraldTranscriptResult"
ClosedPublic

Authored by epriestley on Thu, Feb 18, 5:42 PM.

Details

Summary

Ref T13586. Lift the behavioral core of "HeraldConditionResult" into a new abstract base "HeraldTranscriptResult", with the intent to introduce a "HeraldRuleResult".

Test Plan
  • Ran Herald rules, reviewed transcripts.
  • This change should have no behavioral effect.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 19, 7:16 PM
This revision was automatically updated to reflect the committed changes.