Page MenuHomePhabricator

EditEngineProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Oct 26 2022

epriestley closed T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Resolved.

I filed T13687 as a followup for preventing this particular sort of error (where a Phobject is incorrectly serialized directly).

Oct 26 2022, 7:56 PM · EditEngine, Files

Jul 8 2022

epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

That's very likely the same problem, and I think it should be fixed by updating to the current stable (rPf2a7db1 or newer).

Jul 8 2022, 3:57 AM · EditEngine, Files
Krinkle added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

I believe we may be hitting either the problem one of the above commit fixes, or suffering from a similar caused as side-effect from it.

Jul 8 2022, 3:35 AM · EditEngine, Files

Jun 14 2022

epriestley added a revision to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization: D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:32 PM · EditEngine, Files
epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

...ideally this sort of thing should fail loudly at serialization time...

Jun 14 2022, 4:29 PM · EditEngine, Files
epriestley triaged T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Normal priority.
Jun 14 2022, 1:09 PM · EditEngine, Files

Sep 12 2019

epriestley closed T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Resolved by committing rP41f0b8b0a3a1: Allow subtypes to specify "mutations", to control the behavior of the "Change….
Sep 12 2019, 11:17 PM · EditEngine
epriestley added a revision to T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis: D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action.
Sep 12 2019, 11:12 PM · EditEngine
epriestley triaged T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Low priority.
Sep 12 2019, 10:39 PM · EditEngine

Aug 28 2019

epriestley closed T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation as Resolved by committing rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"….
Aug 28 2019, 1:57 PM · EditEngine

Aug 27 2019

epriestley added a revision to T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation: D20741: Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects.
Aug 27 2019, 2:57 PM · EditEngine
epriestley claimed T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation.
Aug 27 2019, 2:54 PM · EditEngine
epriestley triaged T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation as Normal priority.
Aug 27 2019, 2:54 PM · EditEngine

Jun 19 2019

aeiser added a comment to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.

the (Show Details) would be a great first step for us - and cover our needs. Much like the logs for Herald Rules and other areas.

Jun 19 2019, 10:58 PM · EditEngine
amckinley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Jun 19 2019, 10:19 PM · EditEngine
epriestley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Jun 19 2019, 8:27 PM · EditEngine
epriestley added a comment to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.

There are a few pieces here, since we have to thread the needle through many layers to get where we want to go.

Jun 19 2019, 8:16 PM · EditEngine
epriestley created T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.
Jun 19 2019, 7:54 PM · EditEngine

Apr 2 2019

epriestley closed T12098: Create Revision from FavoritesMenuItem doesn't work, a subtask of T11114: Move Differential to EditEngine, as Resolved.
Apr 2 2019, 10:22 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential

Mar 31 2019

epriestley closed T12127: Allow EditEngine forms to have custom icons as Wontfix.

Since this is at least a little bit of actual work, I'm just going to punt until we see an actual user request.

Mar 31 2019, 9:20 PM · Dashboards, EditEngine

Mar 29 2019

epriestley edited projects for T12127: Allow EditEngine forms to have custom icons, added: Dashboards; removed Profile Menu Item.
Mar 29 2019, 4:34 PM · Dashboards, EditEngine

Feb 1 2019

epriestley closed T12314: Support formal task subtypes (like "bug" vs "feature") as Resolved.

These have existed for a while and recently got support for customizing sub-object behaviors in 2018 Week 50 (Mid December) and are being extended to Projects in 2019 Week 5, so it looks like they're here to stay.

Feb 1 2019, 10:43 PM · EditEngine, Maniphest, Custom Fields, Feature Request

Dec 22 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19934: Restore a Mock key to Pholio Images.
Dec 22 2018, 10:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 20 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19926: Implement Pholio file add/remove transactions without "applyInitialEffects".
Dec 20 2018, 9:53 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19924: Implement "replace" transactions in Pholio without "applyInitialEffects".
Dec 20 2018, 9:33 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19923: Reduce the amount of weird "static" and "cache" behavior in Pholio query classes.
Dec 20 2018, 8:18 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19922: Remove the onboard "mailKey" from Pholio Mocks.
Dec 20 2018, 7:56 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19921: Make the Pholio Mock "getImages" / "getAllImages" API more clear.
Dec 20 2018, 7:48 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley triaged T11351: Move Pholio to EditEngine and modern APIs as Wishlist priority.
Dec 20 2018, 7:48 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.
Dec 20 2018, 6:43 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19919: Remove obsolete, no-op implementations of "willRenderTimeline()".
Dec 20 2018, 6:24 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface.
Dec 20 2018, 6:12 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 19 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19914: Make Images in Pholio refer to mocks by PHID instead of ID.
Dec 19 2018, 7:21 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19913: Give Pholio Images an authorPHID and use ExtendedPolicies to implement policy behavior.
Dec 19 2018, 12:09 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 18 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19912: Un-implement MarkupInterface from Mocks and Images in Pholio.
Dec 18 2018, 11:41 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley updated subscribers of T11351: Move Pholio to EditEngine and modern APIs.

@amckinley, for general context on where I'm headed here:

Dec 18 2018, 11:34 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19911: Give Pholio images a more modern initializer method.
Dec 18 2018, 11:28 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19910: Slightly modernize PholioImageQuery.
Dec 18 2018, 11:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Sep 13 2018

epriestley added subtasks for T13201: Develop a more comprehensive approach for previews/drafts on edit screens: T10859: Wiki page title is not updated in preview, T5811: Phriction does not correctly save and restore document drafts of in-progress edits, T4768: Phabricator silently overwrites concurrent changes (no conflict detection).
Sep 13 2018, 3:28 PM · EditEngine
epriestley added a project to T13201: Develop a more comprehensive approach for previews/drafts on edit screens: EditEngine.
Sep 13 2018, 3:22 PM · EditEngine

Jun 12 2018

epriestley added a revision to T12314: Support formal task subtypes (like "bug" vs "feature"): D19490: Allow object subtypes to be changed via bulk editor.
Jun 12 2018, 5:25 PM · EditEngine, Maniphest, Custom Fields, Feature Request

Jun 5 2018

joshuaspence added a member for EditEngine: joshuaspence.
Jun 5 2018, 10:45 PM

Feb 11 2018

epriestley closed T13071: If you somehow create a draft with an enormous version, it can get stuck in the database for a very long time as Resolved by committing rP5e6e9fcc5652: When purging drafts after a transaction edit, purge all drafts.
Feb 11 2018, 2:01 PM · EditEngine, Transactions
epriestley added a revision to T13071: If you somehow create a draft with an enormous version, it can get stuck in the database for a very long time: D19060: When purging drafts after a transaction edit, purge all drafts.
Feb 11 2018, 1:52 PM · EditEngine, Transactions
epriestley triaged T13071: If you somehow create a draft with an enormous version, it can get stuck in the database for a very long time as Wishlist priority.
Feb 11 2018, 2:03 AM · EditEngine, Transactions

Jul 9 2017

chad removed the image for EditEngine.
Jul 9 2017, 7:32 PM

Jun 14 2017

20after4 added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

It would be really nice to default newly added fields to hidden. Going through 20+ forms to hide the fields is tedious.

Jun 14 2017, 3:06 PM · EditEngine, Maniphest, Custom Fields, Feature Request

May 19 2017

epriestley added a comment to T11440: Drafts for unsaved objects.

I also can't reproduce the original report in the general case: when I type text into the "Create Task" form, click a notification to navigate away, then press "Back", my text is recovered. This is true whether Quicksand is enabled or not.

May 19 2017, 3:10 PM · EditEngine, Feature Request
epriestley added a comment to T11440: Drafts for unsaved objects.

That wouldn't actually address the original problem here (accidentally setting your computer on fire and losing work) but would address the issue in T12731.

May 19 2017, 2:42 PM · EditEngine, Feature Request
epriestley added a comment to T11440: Drafts for unsaved objects.

A possible attack on this is via whatever future abuse system we ultimately might build (T10215).

May 19 2017, 2:41 PM · EditEngine, Feature Request