Page MenuHomePhabricator

Consider implementing "JsonSerializable" in Phobject to forbid serialization
Open, WishlistPublic


See T13685. A class of error where json_serialize(...) is called on a Phobject (which will never work) can be prevented by implementing JsonSerializable and raising a fatal exception.

This is desirable overall (it's fairly bad to poison storage with garbage objects) but it's possible it might surface some pre-existing issues which were otherwise harmless.