Page MenuHomePhabricator

Improve rendering of "default value changed" custom form transactions to at least have all the information
ClosedPublic

Authored by epriestley on Jun 19 2019, 8:27 PM.
Tags
None
Referenced Files
F19941530: D20594.id.diff
Wed, Apr 15, 11:10 AM
F19934348: D20594.id.diff
Sat, Apr 11, 3:09 PM
F19914249: D20594.id49126.diff
Fri, Apr 3, 9:08 AM
F19814394: D20594.diff
Mar 4 2026, 2:00 PM
F19745601: D20594.diff
Feb 15 2026, 3:48 PM
F19633232: D20594.id49126.diff
Feb 5 2026, 6:38 AM
F19617352: D20594.id.diff
Feb 4 2026, 6:01 AM
F19610966: D20594.id49127.diff
Feb 3 2026, 5:18 PM
Subscribers
None

Details

Summary

Ref T13319. Currently, transactions about changes to a default form value use a raw internal key for the affected field and don't show the actual value change.

An ideal implementation will likely require us to specialize a great deal of rendering, but we can do much better than we currently do without too much work:

  • Try to pull the actual EditField object for the key so we can getLabel() it and get a human-readable label (like Visible To instead of policy.view).
  • Add a "(Show Changes)" action that dumps the raw values as more-or-less JSON, so you can at least figure out what happened if you're sophisticated enough.
Test Plan

Before:

Screen Shot 2019-06-19 at 12.52.24 PM.png (367×566 px, 67 KB)

After:

Screen Shot 2019-06-19 at 1.22.49 PM.png (364×647 px, 83 KB)

The quality of "Show Details" varies a lot. For some fields, like "Description", it's pretty good:

Screen Shot 2019-06-19 at 1.23.39 PM.png (211×844 px, 19 KB)

For others, like "Assigned To", it's better than nothing but pretty technical:

Screen Shot 2019-06-19 at 1.27.00 PM.png (233×846 px, 17 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable