Page MenuHomePhabricator

Implement Pholio file add/remove transactions without "applyInitialEffects"
ClosedPublic

Authored by epriestley on Dec 20 2018, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 8:33 PM
Unknown Object (File)
Jan 25 2024, 1:42 AM
Unknown Object (File)
Dec 27 2023, 5:41 PM
Unknown Object (File)
Dec 22 2023, 1:05 AM
Unknown Object (File)
Dec 19 2023, 1:25 PM
Unknown Object (File)
Dec 17 2023, 2:45 PM
Unknown Object (File)
Nov 30 2023, 3:29 AM
Unknown Object (File)
Nov 25 2023, 8:34 PM
Subscribers
None

Details

Summary

Depends on D19924. Ref T11351. Like in D19924, apply these transactions by accepting PHIDs instead of objects so we don't need to juggle the Image objects down to PHIDs in applyInitialEffects.

(Validation is a little light here for now, but only first-party code can reach this, and you can't violate policies or do anything truly bad even if you could pick values to feed in here.)

Test Plan

Created and edited Mocks; added, removed, and reordered images in a Pholio Mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable