Page MenuHomePhabricator

Implement Pholio file add/remove transactions without "applyInitialEffects"

Authored by epriestley on Dec 20 2018, 9:53 PM.



Depends on D19924. Ref T11351. Like in D19924, apply these transactions by accepting PHIDs instead of objects so we don't need to juggle the Image objects down to PHIDs in applyInitialEffects.

(Validation is a little light here for now, but only first-party code can reach this, and you can't violate policies or do anything truly bad even if you could pick values to feed in here.)

Test Plan

Created and edited Mocks; added, removed, and reordered images in a Pholio Mock.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 20 2018, 9:53 PM
epriestley requested review of this revision.Dec 20 2018, 9:55 PM
amckinley accepted this revision.Dec 24 2018, 9:17 PM
This revision is now accepted and ready to land.Dec 24 2018, 9:17 PM
This revision was automatically updated to reflect the committed changes.