Page MenuHomePhabricator

Un-implement MarkupInterface from Mocks and Images in Pholio
ClosedPublic

Authored by epriestley on Dec 18 2018, 11:41 PM.

Details

Summary

Depends on D19911. Ref T11351. MarkupInterface has mostly been replaced with PHUIRemarkupView, and isn't really doing anything for us here. Get rid of it to simplify the code.

Test Plan

Viewed various mocks with descriptions and image descriptions, saw remarkup presented properly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 18 2018, 11:41 PM
epriestley requested review of this revision.Dec 18 2018, 11:43 PM
  • Remove some constants.
amckinley accepted this revision.Dec 18 2018, 11:59 PM
This revision is now accepted and ready to land.Dec 18 2018, 11:59 PM
This revision was automatically updated to reflect the committed changes.