Page MenuHomePhabricator

Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action
ClosedPublic

Authored by epriestley on Sep 12 2019, 11:12 PM.

Details

Summary

Fixes T13415. Provide a way for subtypes to customize the behavior of "Change Subtype" actions that appear above comment areas.

Subtypes may disable this action by specifying "mutations": [], or provide a list of subtypes.

The bulk editor and API can still perform any change.

Test Plan
  • Tried to define an invalid "mutations" list with a bad subtype, got a sensible error.
  • Specified a limited mutations list and an empty mutations list, verified that corresponding tasks got corresponding actions.
  • Used the bulk editor to perform a freeform mutation.
  • Verified that tasks of a subtype with no "mutations" still work the same way they used to (allow mutation into any subtype).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 12 2019, 11:12 PM
epriestley requested review of this revision.Sep 12 2019, 11:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 11:17 PM
This revision was automatically updated to reflect the committed changes.