Page MenuHomePhabricator

Make the Pholio Mock "getImages" / "getAllImages" API more clear
ClosedPublic

Authored by epriestley on Dec 20 2018, 7:48 PM.

Details

Summary

Depends on D19920. Ref T11351. Currently, "images" and "all images" are attached to Mocks separately, and getImages() gets you only some images.

Clean this up slightly:

  • One attach method; attach everything.
  • Two getters, one for "images" (returns all images); one for "active images" (returns active images).
Test Plan

Browsed around Pholio without any apparent behavioral changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/pholio/storage/PholioMock.php
121

This was a bug, should have asserted allImages instead.

This revision is now accepted and ready to land.Dec 20 2018, 10:00 PM
This revision was automatically updated to reflect the committed changes.