Page MenuHomePhabricator

When purging drafts after a transaction edit, purge all drafts
ClosedPublic

Authored by epriestley on Feb 11 2018, 1:52 PM.
Tags
None
Referenced Files
F13092345: D19060.diff
Thu, Apr 25, 3:41 AM
Unknown Object (File)
Sat, Mar 30, 6:45 PM
Unknown Object (File)
Sat, Mar 30, 6:45 PM
Unknown Object (File)
Sat, Mar 30, 6:45 PM
Unknown Object (File)
Mar 12 2024, 4:59 PM
Unknown Object (File)
Feb 20 2024, 9:32 PM
Unknown Object (File)
Feb 20 2024, 8:16 PM
Unknown Object (File)
Feb 19 2024, 11:56 AM
Subscribers
None

Details

Summary

Fixes T13071. See that task for discusison. I think this <= version constraint is needless in normal cases (it should match everything in the table anyway), and slightly harmful in bizarre cases where a draft somehow gets a much larger ID than it should have.

Test Plan
  • Gave a draft an unreasonably large ID.
  • Pre-patch, observed: submitting comments on the draft's object does not clear the draft.
  • Post-patch: submitting comments on the draft's object now clears the draft correctly.
  • Also added comments/actions, reloaded pages, saw drafts stick properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.