Page MenuHomePhabricator

When purging drafts after a transaction edit, purge all drafts
ClosedPublic

Authored by epriestley on Feb 11 2018, 1:52 PM.
Tags
None
Referenced Files
F18842285: D19060.id45696.diff
Oct 28 2025, 2:40 PM
F18805806: D19060.id45694.diff
Oct 18 2025, 4:35 PM
F18803345: D19060.id.diff
Oct 17 2025, 10:58 PM
F18752998: D19060.id.diff
Oct 4 2025, 5:03 PM
F18745218: D19060.diff
Oct 3 2025, 5:46 AM
F18652003: D19060.diff
Sep 21 2025, 6:16 AM
F18566578: D19060.id.diff
Sep 9 2025, 2:44 PM
F18502129: D19060.diff
Sep 4 2025, 10:13 PM
Subscribers
None

Details

Summary

Fixes T13071. See that task for discusison. I think this <= version constraint is needless in normal cases (it should match everything in the table anyway), and slightly harmful in bizarre cases where a draft somehow gets a much larger ID than it should have.

Test Plan
  • Gave a draft an unreasonably large ID.
  • Pre-patch, observed: submitting comments on the draft's object does not clear the draft.
  • Post-patch: submitting comments on the draft's object now clears the draft correctly.
  • Also added comments/actions, reloaded pages, saw drafts stick properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.