Paths

Table of Contentst

Differential D19060

When purging drafts after a transaction edit, purge all drafts
ClosedPublic
Actions

Authored by epriestley on Feb 11 2018, 1:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 5:21 AM

	Unknown Object (File)
	Sun, Feb 9, 5:21 AM

	Unknown Object (File)
	Sun, Feb 9, 5:21 AM

	Unknown Object (File)
	Wed, Jan 29, 1:46 AM

	Unknown Object (File)
	Fri, Jan 24, 11:58 PM

	Unknown Object (File)
	Fri, Jan 24, 11:57 PM

	Unknown Object (File)
	Fri, Jan 24, 11:57 PM

	Unknown Object (File)
	Tue, Jan 21, 11:14 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13071: If you somehow create a draft with an enormous version, it can get stuck in the database for a very long time
Commits: rP5e6e9fcc5652: When purging drafts after a transaction edit, purge all drafts

Summary

Fixes T13071. See that task for discusison. I think this <= version constraint is needless in normal cases (it should match everything in the table anyway), and slightly harmful in bizarre cases where a draft somehow gets a much larger ID than it should have.

Test Plan

Gave a draft an unreasonably large ID.
Pre-patch, observed: submitting comments on the draft's object does not clear the draft.
Post-patch: submitting comments on the draft's object now clears the draft correctly.
Also added comments/actions, reloaded pages, saw drafts stick properly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 11 2018, 1:52 PM

Harbormaster completed remote builds in B19497: Diff 45694.Feb 11 2018, 1:53 PM

epriestley requested review of this revision.Feb 11 2018, 1:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 2:01 PM

Closed by commit rP5e6e9fcc5652: When purging drafts after a transaction edit, purge all drafts (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

draft/

storage/

PhabricatorVersionedDraft.php

9 lines

transactions/

editengine/

PhabricatorEditEngine.php

3 lines

Diff 45696

src/applications/draft/storage/PhabricatorVersionedDraft.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...