Page MenuHomePhabricator

Make Images in Pholio refer to mocks by PHID instead of ID
ClosedPublic

Authored by epriestley on Dec 19 2018, 7:21 PM.
Tags
None
Referenced Files
F12850583: D19914.diff
Fri, Mar 29, 5:34 AM
Unknown Object (File)
Sat, Mar 23, 5:43 PM
Unknown Object (File)
Fri, Mar 22, 9:49 PM
Unknown Object (File)
Feb 4 2024, 3:55 AM
Unknown Object (File)
Feb 3 2024, 8:29 PM
Unknown Object (File)
Jan 25 2024, 1:40 AM
Unknown Object (File)
Jan 18 2024, 11:33 PM
Unknown Object (File)
Dec 22 2023, 1:03 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T11351. In Pholio, we currently use a mockID, but a mockPHID is generally preferable / more modern / more flexible. In particular, we need PHIDs to load handles and prefer PHIDs when exposing information to the API, and using PHIDs internally makes a bunch of things easier/better/faster and ~nothing harder/worse/slower.

I'll add some inlines about a few things.

Test Plan

Ran migrations, spot-checked database for sanity. Loaded Pholio, saw data unchanged. Created and edited images.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Dec 19 2018, 7:21 PM
src/applications/pholio/query/PholioImageQuery.php
29–32

This has no callers, so I removed it for now. Previously, I believe Pholio only showed current versions of images, so this probably dates to that earlier time.

src/applications/pholio/storage/PholioImage.php
40–47

For now, I've just removed these keys:

  • We'll get an automatic key_phid on bin/storage upgrade by default now that we're no longer suppressing it with null.
  • We should have some kind of key_mock, but since isObsolete is never queried for it probably shouldn't be <mock, isObsolete, ...>. I'll add this key back once I figure out what it should be.
This revision is now accepted and ready to land.Dec 19 2018, 9:49 PM
This revision was automatically updated to reflect the committed changes.
src/applications/pholio/storage/PholioMock.php
262

I missed updating the actual method call here, later fixed in D21081.