Differential D19911

Give Pholio images a more modern initializer method
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 11:28 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T11351: Move Pholio to EditEngine and modern APIs

Commits

rP1d84b5b86b84: Give Pholio images a more modern initializer method

Summary

Depends on D19910. Ref T11351. Minor changes to make this behave in a more modern way.

Test Plan

Destroyed a mock.
Lipsum'd a mock.
Poked around, edited/viewed mocks.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 18 2018, 11:28 PM

Harbormaster completed remote builds in B21380: Diff 47526.Dec 18 2018, 11:29 PM

epriestley requested review of this revision.Dec 18 2018, 11:29 PM

amckinley accepted this revision.Dec 18 2018, 11:32 PM

This revision is now accepted and ready to land.Dec 18 2018, 11:32 PM

epriestley added a child revision: D19912: Un-implement MarkupInterface from Mocks and Images in Pholio.Dec 18 2018, 11:41 PM

Closed by commit rP1d84b5b86b84: Give Pholio images a more modern initializer method (authored by epriestley). · Explain WhyDec 19 2018, 6:47 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D21081: Fix an out-of-date API call on the destruction pathway for Pholio mocks.Apr 10 2020, 3:00 PM

epriestley mentioned this in rPc3be82fe6e09: Fix an out-of-date API call on the destruction pathway for Pholio mocks.Apr 10 2020, 3:01 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

controller/

PholioImageUploadController.php

2 lines

PholioMockEditController.php

4 lines

lipsum/

PhabricatorPholioMockTestDataGenerator.php

9 lines

storage/

PholioImage.php

18 lines

PholioMock.php

7 lines

Diff 47531

View Options

src/applications/pholio/controller/PholioImageUploadController.php

View Options

src/applications/pholio/controller/PholioMockEditController.php

View Options

src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php

View Options

src/applications/pholio/storage/PholioImage.php

View Options

src/applications/pholio/storage/PholioMock.php

Give Pholio images a more modern initializer methodClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47531

src/applications/pholio/controller/PholioImageUploadController.php

src/applications/pholio/controller/PholioMockEditController.php

src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php

src/applications/pholio/storage/PholioImage.php

src/applications/pholio/storage/PholioMock.php

Give Pholio images a more modern initializer method
ClosedPublic
Actions

Revision Contents
Changeset List