DifferentialProject
ActivePublic

Details

Description

Differential is a code review tool.

Recent Activity

Tue, Jan 16

epriestley added a comment to T13023: Non-standard patches lead to exceptions being generated.

Tangential, but T8768 is a case where we generated an unfaithful synthetic diff (a diff --git that the git binary could not generate since 2006) and took the blame for it.

Tue, Jan 16, 10:22 PM · Differential
epriestley closed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them , a subtask of T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats, as Resolved.
Tue, Jan 16, 9:57 PM · Arcanist, Differential

Fri, Jan 5

epriestley moved T8768: Under Mercurial, `arc patch` mishandles files with spaces in them from Backlog to arc patch on the Mercurial board.
Fri, Jan 5, 6:56 PM · Git, Mercurial, Arcanist
epriestley closed T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured, a subtask of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, as Resolved.
Fri, Jan 5, 6:47 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured as Resolved.

The install in PHI271 reported this as fixed after upgrading.

Fri, Jan 5, 6:47 PM · Mail, Differential

Thu, Jan 4

epriestley added a commit to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: rPc12a6cac7603: (stable) Fix a minor/harmless race with feed publishers in certain draft states.
Thu, Jan 4, 4:15 PM · Mail, Differential
epriestley added a commit to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: rP33f7f65e81d4: (stable) Always show "X requested review" in mail to stop some undraft mail….
Thu, Jan 4, 4:15 PM · Mail, Differential
epriestley added a commit to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: rP129e3a120849: Fix a minor/harmless race with feed publishers in certain draft states.
Thu, Jan 4, 4:15 PM · Mail, Differential
epriestley added a commit to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: rPde6c68b91e57: Always show "X requested review" in mail to stop some undraft mail from being….
Thu, Jan 4, 4:14 PM · Mail, Differential

Wed, Jan 3

epriestley added a revision to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: D18852: Fix a minor/harmless race with feed publishers in certain draft states.
Wed, Jan 3, 9:58 PM · Mail, Differential
epriestley added a revision to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: D18851: Always show "X requested review" in mail to stop some undraft mail from being dropped.
Wed, Jan 3, 9:43 PM · Mail, Differential
epriestley added a subtask for T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured.
Wed, Jan 3, 9:40 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added parent tasks for T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: T13010: Upgrading: Differential Draft State, T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Wed, Jan 3, 9:40 PM · Mail, Differential
epriestley triaged T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured as Normal priority.
Wed, Jan 3, 9:40 PM · Mail, Differential

Wed, Dec 27

epriestley added a commit to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to: rP153c05465875: (stable) Add an "Accepting reviewers" Herald field for commits.
Wed, Dec 27, 12:00 AM · Differential, Herald, Bug Report

Tue, Dec 26

epriestley closed T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to as Resolved by committing rPead5f4fd9c03: Add an "Accepting reviewers" Herald field for commits.
Tue, Dec 26, 11:59 PM · Differential, Herald, Bug Report
epriestley added a comment to T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.

T13023 provides an example of a synthetic "git-like" diff generated by some tool (dpkg-source?) which appears (?) to pretend to generate Git diffs (diff --git in the text).

Tue, Dec 26, 7:29 PM · Arcanist, Differential
epriestley merged T13023: Non-standard patches lead to exceptions being generated into T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Tue, Dec 26, 7:29 PM · Arcanist, Differential
epriestley merged task T13023: Non-standard patches lead to exceptions being generated into T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Tue, Dec 26, 7:29 PM · Differential
epriestley added a comment to T13023: Non-standard patches lead to exceptions being generated.

I'll merge this into T12664, but realistically it's exceptionally unlikely that we'll add the ability to parse these diffs given one example and no idea how to generate them in the general case, and apparently only one install encounters these diffs, and they aren't generated with a legitimate VCS tool.

Tue, Dec 26, 7:28 PM · Differential

Fri, Dec 22

epriestley added a revision to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to: D18839: Add an "Accepting reviewers" Herald field for commits.
Fri, Dec 22, 6:19 PM · Differential, Herald, Bug Report

Dec 13 2017

epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

No.

Dec 13 2017, 2:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
mpadourek added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@epriestley Are there any more concrete plans for this "nonblocking" builds? That is something we would like to utilise for one of our projects. Actually quite important as waiting for builds there is slowing us down quite a bit now.

Dec 13 2017, 2:18 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Dec 5 2017

epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP6d3baa92f908: Execute Herald again after promoting revisions out of the "Draft" state.
Dec 5 2017, 8:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit, a subtask of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, as Resolved.
Dec 5 2017, 8:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Resolved by committing rP6d3baa92f908: Execute Herald again after promoting revisions out of the "Draft" state.
Dec 5 2017, 8:14 PM · Herald, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Dec 5 2017, 3:57 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit: D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Dec 5 2017, 3:57 PM · Herald, Differential

Dec 1 2017

epriestley triaged T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Normal priority.
Dec 1 2017, 7:32 PM · Herald, Differential

Nov 28 2017

epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP1b76250f8995: Disallow "Accept" on drafts, allow "Resign".
Nov 28 2017, 9:46 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP54f131dc4baa: Make "first broadcast" rules for Differential drafts more general.
Nov 28 2017, 9:42 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D18802: Disallow "Accept" on drafts, allow "Resign".
Nov 28 2017, 7:09 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D18801: Make "first broadcast" rules for Differential drafts more general.
Nov 28 2017, 6:45 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Nov 23 2017

bcooksley created T13023: Non-standard patches lead to exceptions being generated.
Nov 23 2017, 9:17 AM · Differential
aik099 added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Nov 23 2017, 7:28 AM · Profile Menu Item, Differential, Bug Report
sshannin added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Nov 23 2017, 3:33 AM · Profile Menu Item, Differential, Bug Report

Nov 22 2017

yurivict added a comment to T2495: Improve whitespace expansion of tab literals.

Phabricator messes up tab spacing in patches. It should be very easy to replace tabs with spaces and require the use of only monospace fonts.

Nov 22 2017, 6:22 AM · Restricted Project, FreeBSD, Differential, Diffusion

Nov 14 2017

epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rPc098aec66931: (stable) Restore "Summary" and "Test Plan" to initial mail for non-draft….
Nov 14 2017, 8:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP314e7266c3e5: Restore "Summary" and "Test Plan" to initial mail for non-draft configurations.
Nov 14 2017, 8:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D18771: Restore "Summary" and "Test Plan" to initial mail for non-draft configurations.
Nov 14 2017, 8:13 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a project to T13014: Improve design of "Owns No Changed Paths" flag in Differential: Differential.
Nov 14 2017, 4:02 PM · Differential, Design & Planning

Nov 7 2017

epriestley added a commit to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: rP759c757264c8: Include "Draft" revisions in Differential legacy status queries.
Nov 7 2017, 11:35 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

(Another possibility is to add behavior to arc to control this.)

Nov 7 2017, 1:50 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Maybe. Another possibility is to mark builds as "nonblocking" in some sense. There are some other open requests for defining "advisory" or "noncritical" builds where build failure doesn't cause the Buildable to report a failed result overall. If we end up adding this state to builds anyway, it probably makes sense to include a "Does Not Block Review" flag to the "Does Not Fail Buildable" / "Does Not Block Dependent Builds" / "Failure Is Totally Meaningless" / Whatever flags.

Nov 7 2017, 1:28 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D18765: Include "Draft" revisions in Differential legacy status queries.
Nov 7 2017, 1:17 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
jmeador added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

The harbormaster builds that we have running on revision creation can sometimes be rather slow; they're builds in our primary CI system, but with less of a priority than jobs in the submit queue. This will result in 10-30 minute delays for every revision in our monorepo. I understand the preference for only adding configuration settings when absolutely necessary, but since this may result in a significant time sink for any installs with expensive builds, is it worth keeping something around like differential.initial-state?

Nov 7 2017, 7:31 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Nov 2 2017

epriestley added a commit to T12689: Mail is still received after resigning from a revision: rP03d059dd26e2: Don't include resigned reviewers in the Differential "To" list.
Nov 2 2017, 12:22 AM · Mail, Differential, Bug Report
epriestley closed T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review" as Resolved by committing rP6ecdadb76a95: After "Request Review", move revisions with voided "Accepts" into "Ready to….
Nov 2 2017, 12:20 AM · Differential
epriestley added a commit to T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review": rP6d36eb911309: Denormalize Diff PHIDs onto Revisions.
Nov 2 2017, 12:19 AM · Differential

Nov 1 2017

epriestley added a revision to T12689: Mail is still received after resigning from a revision: D18758: Don't include resigned reviewers in the Differential "To" list.
Nov 1 2017, 6:12 PM · Mail, Differential, Bug Report