Page MenuHomePhabricator

DifferentialProject
ActivePublic

Details

Description

Differential is a code review tool.

Recent Activity

Thu, Feb 13

epriestley closed T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential as Resolved by committing rPdc35ce79e484: Unprototype "Draft" mode in Differential.
Thu, Feb 13, 12:20 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Wed, Feb 12

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D20983: Unprototype "Draft" mode in Differential.
Wed, Feb 12, 11:48 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Tue, Feb 4

epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx", a subtask of T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships, as Resolved.
Tue, Feb 4, 3:05 PM · Customer Impact, Maniphest, Differential
epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Resolved by committing rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if….
Tue, Feb 4, 3:05 PM · Maniphest, Differential, Diffusion

Mon, Feb 3

epriestley added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

I just wanted to hold it across the release cut, it's headed to master shortly.

Mon, Feb 3, 7:02 PM · Maniphest, Differential, Diffusion
swisspol added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

@epriestley what's blocking landing this diff?

Mon, Feb 3, 6:46 PM · Maniphest, Differential, Diffusion

Thu, Jan 30

epriestley closed T13440: Provide a richer "Revisions/Commits" UI in Maniphest as Resolved.

Sounds good. It felt slightly odd to me at first, too, but I think I also got used to it.

Thu, Jan 30, 8:16 PM · Diffusion, Differential, Maniphest
swisspol added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

It wasn't a major UI issue to start with and yes, you get used to it. I would ignore.

Thu, Jan 30, 7:37 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden.
Thu, Jan 30, 6:45 PM · Differential
epriestley added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

The empty space means "this is a normal commit with no special audit state", and the column collapses if no commits have issues (see this task for an example). That seems fairly reasonable to me?

Thu, Jan 30, 6:42 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists).
Thu, Jan 30, 6:32 PM · Maniphest, Differential, Diffusion
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

The underlying code is still a bit shaky, so let me know if you catch other issues.

Thu, Jan 30, 4:31 PM · Differential
epriestley closed T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view as Resolved by committing rPccf28a81121e: Fix an issue where the last line of block-based diffs could be incorrectly….
Thu, Jan 30, 4:19 PM · Differential
epriestley added a revision to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view: D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden.
Thu, Jan 30, 4:17 PM · Differential
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

In DifferentialHunkParser->generateVisibleLinesMask(), we pass a 0-based array in and get a 1-based ("line number") array out. The loop condition stops us from reaching the last line of the 0-based array.

Thu, Jan 30, 3:54 PM · Differential
epriestley triaged T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view as Low priority.
Thu, Jan 30, 3:36 PM · Differential
epriestley added a project to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view: Differential.
Thu, Jan 30, 3:36 PM · Differential

Nov 21 2019

epriestley removed a parent task for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T10034: Plan the future of Maniphest task relationships.
Nov 21 2019, 4:06 PM · Customer Impact, Maniphest, Differential
epriestley merged T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:05 PM · Maniphest, Differential, Diffusion
epriestley added a subtask for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley added a subtask for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:03 PM · Customer Impact, Maniphest, Differential
epriestley added a parent task for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley updated the task description for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley triaged T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Low priority.
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley closed T5598: Make "T123" in commit title work like "Ref T123" or "Fixes T123" in the body or test plan or a comment as Wontfix.

I don't currently plan to pursue this.

Nov 21 2019, 3:56 PM · Differential, Maniphest

Nov 13 2019

epriestley claimed T13455: Make "View Options" in Differential sticky across reloads.
Nov 13 2019, 4:07 PM · Differential
epriestley triaged T13455: Make "View Options" in Differential sticky across reloads as Low priority.
Nov 13 2019, 4:07 PM · Differential

Nov 8 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Nov 8 2019, 3:35 PM · Differential

Nov 4 2019

swisspol added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

Layout looks very neat but a strange too with that big space gap between the icon on each row and the actual text in this case:

Nov 4 2019, 7:57 PM · Diffusion, Differential, Maniphest

Nov 1 2019

epriestley renamed T13440: Provide a richer "Revisions/Commits" UI in Maniphest from Provide a richer "Changes" UI in Maniphest to Provide a richer "Revisions/Commits" UI in Maniphest.
Nov 1 2019, 4:35 PM · Diffusion, Differential, Maniphest

Oct 31 2019

epriestley added a revision to T13440: Provide a richer "Revisions/Commits" UI in Maniphest: D20885: Clean up "Revisions/Commits" table in Maniphest slightly.
Oct 31 2019, 7:27 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13440: Provide a richer "Revisions/Commits" UI in Maniphest: D20884: Add support for rendering section dividers in tables; use section dividers for changes on tasks.
Oct 31 2019, 7:01 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13440: Provide a richer "Revisions/Commits" UI in Maniphest: D20883: Show commits and revisions on tasks in a tabular view instead of handle lists.
Oct 31 2019, 6:13 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13440: Provide a richer "Revisions/Commits" UI in Maniphest: D20882: Remove "State Icons" from handles.
Oct 31 2019, 6:10 PM · Diffusion, Differential, Maniphest
epriestley triaged T13440: Provide a richer "Revisions/Commits" UI in Maniphest as Low priority.
Oct 31 2019, 5:05 PM · Diffusion, Differential, Maniphest

Oct 29 2019

epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

After D20877, we'll forcefully override this option when generating diffs internally.

Oct 29 2019, 5:15 PM · Differential
epriestley added a revision to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: D20877: When generating diffs in "arc diff", disable Git config option "diff.suppressBlankEmpty".
Oct 29 2019, 5:12 PM · Differential
epriestley updated the task description for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 29 2019, 5:04 PM · Differential
epriestley closed T13437: "Jump to Symbol" URIs from diff views are built without proper escaping as Resolved by committing rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them.
Oct 29 2019, 4:48 PM · Diffusion, Differential
epriestley updated the task description for T13437: "Jump to Symbol" URIs from diff views are built without proper escaping.
Oct 29 2019, 4:48 PM · Diffusion, Differential
epriestley added a revision to T13437: "Jump to Symbol" URIs from diff views are built without proper escaping: D20876: Trim and URI encode symbol names before building URIs from them.
Oct 29 2019, 4:41 PM · Diffusion, Differential
epriestley triaged T13437: "Jump to Symbol" URIs from diff views are built without proper escaping as Low priority.
Oct 29 2019, 4:32 PM · Diffusion, Differential

Oct 26 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine.
Oct 26 2019, 7:09 PM · Differential

Oct 25 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20865: Support rich diff rendering with DocumentEngine for added/removed files.
Oct 25 2019, 6:47 PM · Differential

Oct 24 2019

epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

One change we can make here is to explicitly specify -c diff.suppressBlankEmpty false in the arc diff command, as we currently use --src-prefix and --dst-prefix to override diff.mnemonicprefix. This is likely desirable, but it would be good to also parse these diffs properly if they arrive through --raw or copy/pasting, etc.

Oct 24 2019, 11:02 PM · Differential
epriestley renamed T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Diffs that have had tailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly to Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Differential
epriestley added a parent task for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Oct 24 2019, 2:43 AM · Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Arcanist, Differential
epriestley triaged T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly as Wishlist priority.
Oct 24 2019, 2:43 AM · Differential

Oct 2 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20851: In Jupyter notebooks, apply intraline diffing to source code lines.
Oct 2 2019, 3:50 PM · Differential