Page MenuHomePhabricator

DifferentialProject
ActivePublic

Details

Description

Differential is a code review tool.

Recent Activity

Oct 19 2021

epriestley added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".
  1. As Alice, commandeer a revision authored by Baliey and reviewed by Claire. Edit it locally to do arbitrary bad things, then git push it.
  2. Make a commit, edit the commit message to say Differential Revision: D1234, where D1234 is a current, valid, accepted revision authored by anyone, then git push it.
Oct 19 2021, 6:25 PM · Differential
epriestley added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

I believe it is extremely difficult to configure Phabricator to provide the assurance you describe, particularly if arc land does anything. If you are actually providing this guarantee ("an attacker needs two machines"), you can likely add a clause to the large amount of custom code you've written to prevent self-foisting while still supporting other foisting use cases. If you haven't written a large amount of custom code, I suspect an attacker can fairly easily deploy with one machine without using "Foist Upon".

Oct 19 2021, 6:18 PM · Differential
ptarjan added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

Is there a way to disable this feature? Our security team has noticed that with this feature we can land code with just a single person's machine being compromised (we rely on an attacker needing two machines to deploy code as a safety mechanism). I.e. You make a revision, Foist it on someone, Approve it, then arc land it as the other person (saying y to the prompt).

Oct 19 2021, 5:48 PM · Differential

May 12 2021

epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
May 12 2021, 4:13 PM · Differential, Plans

Mar 26 2021

epriestley closed T13639: Allow revisions to be queried by affected path via the API as Resolved.

This is now in stable; presuming it works until evidence to the contrary emerges.

Mar 26 2021, 6:08 PM · Conduit, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 26 2021, 3:48 PM · Accessibility, Differential

Mar 25 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 9:14 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 9:13 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Mar 25 2021, 9:12 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21653: Formally track "initial", "committed", and "active" states for inline comments.
Mar 25 2021, 9:10 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21652: When creating an inline comment, populate the content state with the default suggestion text.
Mar 25 2021, 9:07 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21651: On inline comments, track an explicit "committed" content state.
Mar 25 2021, 9:05 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21650: Fix an issue when undoing mutiple inline comment deletions.
Mar 25 2021, 9:03 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21649: Make the client authoritative for "Cancel" actions.
Mar 25 2021, 9:00 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21648: Make the client authoritative for "Save" actions.
Mar 25 2021, 8:58 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21647: Remove direct reads of form state from main Inline client code.
Mar 25 2021, 8:56 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21646: Make client inlines track an "active" state.
Mar 25 2021, 8:54 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mar 25 2021, 8:51 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

The "Cancel" button should mean "Delete" if...

Mar 25 2021, 8:21 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 6:16 PM · Accessibility, Differential

Mar 23 2021

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Currently, the inline code partially conflates four separate content states:

Mar 23 2021, 5:57 PM · Accessibility, Differential

Mar 22 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 22 2021, 6:13 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

When you "Quote" a comment, then cancel, the comment disappears from the UI.

Mar 22 2021, 5:36 PM · Accessibility, Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 22 2021, 5:32 PM · Differential
epriestley added a comment to T13534: Inline Comment errata after editing persistence.

When you are viewing a change under engine X, and comments made under engine Y are present, they are not handled specially.

Mar 22 2021, 5:32 PM · Differential
epriestley updated the task description for T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file.
Mar 22 2021, 5:31 PM · Differential

Mar 18 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 18 2021, 6:45 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 18 2021, 6:39 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21642: Fix an issue where inlines could be duplicated in the client list.
Mar 18 2021, 6:33 PM · Accessibility, Differential

Mar 17 2021

epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

A general concern with "batch processing" is that it's quite bad if one commit failing to import can stall the entire repository forever.

Mar 17 2021, 11:18 PM · Diffusion, Differential
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

See also T13552, which modifies the above discussion. The "Update" steps now happen after the "Publish" step.

Mar 17 2021, 11:12 PM · Diffusion, Differential
epriestley closed T13425: Support diffs between abstract block lists in the UI as Resolved.

The bulk of this work is done and I think there's nothing unique and actionable left here. This is survived by T13642 and other issues.

Mar 17 2021, 11:07 PM · Differential
epriestley closed T13515: Differential: Inlines and View Options as Resolved.

Survived by T13534, etc.

Mar 17 2021, 11:01 PM · Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 17 2021, 11:00 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Mar 17 2021, 11:00 PM · Differential
epriestley closed T13513: Make schema changes to inlines to prepare for new inline features as Resolved.

When you are viewing a document with engine X, and comments originally made with engine Y are present, this should be indicated ("This comment was made while looking at this change as a Q document."). They should probably also be moved to the top/bottom of the file, at least by default, since "Jupyter line number 9 = raw source line number 9" is an exceptionally bad and confusing guess at how to map line numbers.

Mar 17 2021, 10:59 PM · Inline Comments, Diffusion, Differential
epriestley closed T13513: Make schema changes to inlines to prepare for new inline features, a subtask of T13515: Differential: Inlines and View Options, as Resolved.
Mar 17 2021, 10:59 PM · Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 17 2021, 10:59 PM · Differential
epriestley closed T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Resolved.

Some tag stuff ended up here; I moved it to T13645.

Mar 17 2021, 10:47 PM · Differential
epriestley updated the task description for T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.
Mar 17 2021, 10:46 PM · Differential
epriestley closed T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup as Resolved.
Mar 17 2021, 10:32 PM · Differential
epriestley added a revision to T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup: D21641: Correct minor "jump to symbol" behavior in Differential.
Mar 17 2021, 10:30 PM · Differential
epriestley closed T9764: Lint star colors have different meaning for revisions and diffs as Resolved.
  • Colors are now consistent.
  • Icons no longer use only color to communicate information.
  • Icons are (mostly) consistent with the Harbormaster icons that have similar meanings.
  • See ConfigModules/ExtensionsConstants: Differential.
Mar 17 2021, 8:45 PM · Restricted Project, Differential
epriestley added a revision to T9764: Lint star colors have different meaning for revisions and diffs: D21640: Replace Differential "lint stars" with icons.
Mar 17 2021, 8:44 PM · Restricted Project, Differential
epriestley added a revision to T9764: Lint star colors have different meaning for revisions and diffs: D21639: Replace Differential "unit stars" with icons.
Mar 17 2021, 8:26 PM · Restricted Project, Differential
epriestley closed T8591: Undefined index in changeset parser as Resolved.

The diff above no longer reproduces this, and I think an equivalent to D18302 landed in D21178. T13524 was almost certainly the same issue.

Mar 17 2021, 7:32 PM · Differential
epriestley moved T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup from Backlog to Next on the Differential board.
Mar 17 2021, 7:30 PM · Differential
epriestley triaged T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup as Low priority.
Mar 17 2021, 7:29 PM · Differential
epriestley closed T9298: Lint/unittest excuses overwrite each other as Resolved.

This is mooted because I've removed the "excuses" feature about a year ago -- on the balance, I think it generated more confusion and busywork than signal.

Mar 17 2021, 7:26 PM · Differential
epriestley renamed T13643: Permissions and UI around manual web "Update Diff" workflow are inconsistent from Permissions around manual web "Update Diff" workflow are inconsistent to Permissions and UI around manual web "Update Diff" workflow are inconsistent.
Mar 17 2021, 7:23 PM · Differential