DifferentialProject
ActivePublic

Details

Description

Differential is a code review tool.

Recent Activity

Fri, Jun 1

epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering….
Fri, Jun 1, 9:53 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI.
Fri, Jun 1, 8:14 PM · Plans, Files, Differential, Diffusion

May 12 2018

Herald updated subscribers of T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
May 12 2018, 2:11 PM · Restricted Project, Audit, Differential

May 9 2018

epriestley closed T1246: Intraline diff bailout at 80 characters is inflexible and undesirable as Resolved by committing rARCa1aec701e3ea: Raise the intraline diff hard limit from 80 to 100 characters.
May 9 2018, 8:38 PM · Differential
epriestley added a comment to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable.

D19442 is marked as fixing this, although it just raises the limit from 80 to 100. This span measures the number of characters between the first changed character and the last changed character (not the total number of characters on the line) and we haven't seen tons of interest in this over the last several years so I think few installs are running into issues with it even at 80. Bumping it to 100 should give us a bit more breathing room but I don't currently plan to make it configurable (see T8227).

May 9 2018, 8:37 PM · Differential
epriestley added a revision to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable: D19442: Raise the intraline diff hard limit from 80 to 100 characters.
May 9 2018, 8:33 PM · Differential

Apr 30 2018

epriestley added a commit to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: rPee32c186dd82: Stop computing ownership for changed paths for Very Large revisions.
Apr 30 2018, 10:44 PM · Plans, Differential
epriestley added a commit to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: rP24305cadb902: Hide the "large" diff warning on "very large" diffs.
Apr 30 2018, 10:33 PM · Plans, Differential
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rPafc3099ee785: Add a view option to disable blame in Diffusion and fix some view transition….
Apr 30 2018, 10:32 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: D19418: Stop computing ownership for changed paths for Very Large revisions.
Apr 30 2018, 7:15 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: D19416: Hide the "large" diff warning on "very large" diffs.
Apr 30 2018, 6:55 PM · Plans, Differential
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 30 2018, 6:47 PM · Plans, Differential

Apr 28 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19414: Add a view option to disable blame in Diffusion and fix some view transition bugs.
Apr 28 2018, 1:55 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

From PHI604, for completeness, on the newer behavior of "Hide Blame":

Apr 28 2018, 1:52 PM · Plans, Files, Differential, Diffusion

Apr 26 2018

chad added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

Yeah, I'm looking at here, assuming it's ahead of last release.

Apr 26 2018, 11:06 PM · Design & Planning, Differential, Plans
epriestley added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

Just to make sure we're talking about the same thing, that feedback is true even of the version at HEAD (blue/grey/orange) vs the version that originally shipped (green/grey/red)?

Apr 26 2018, 10:48 PM · Design & Planning, Differential, Plans
chad added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

You could maybe leave the element off unless it is a larger change. I think my concern here is seeing it on every revision becomes something extra I have to mentally process, but if the intent is to either help show small changes, or large changes, it could just be visible in those edge cases. In those cases at least, the element provides context as to why it's shown at all vs. all the time?

Apr 26 2018, 10:43 PM · Design & Planning, Differential, Plans
epriestley added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

I think there's possibly at least some argument that this element could serve noble goals:

Apr 26 2018, 10:37 PM · Design & Planning, Differential, Plans
chad added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

I feel your instincts are correct, this information isn't useful in a list form and shouldn't be included. You could make the argument to include it in a hovercard, or bring it into the header on the diff page, and I think those are both fine. Outside of that this seems mostly geared towards avoiding code review, a practice I don't think is well aligned with the overall product goals.

Apr 26 2018, 9:16 PM · Design & Planning, Differential, Plans

Apr 24 2018

bgamari added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@epriestley, can you confirm that the above patch should disable the draft state? I have applied it to GHC's Phabricator deployment yet we are still seeing Differentials opened in draft state.

Apr 24 2018, 5:01 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Apr 20 2018

epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 20 2018, 1:08 AM · Plans, Differential
epriestley added a commit to T13127: Plans: Form Steering Committee For "+/-" Line Indicators: rP19403fdb8e29: Improve color use in "[+++- ]" element for colorblind users.
Apr 20 2018, 12:24 AM · Design & Planning, Differential, Plans

Apr 19 2018

epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 19 2018, 7:56 PM · Plans, Differential
epriestley added a revision to T13127: Plans: Form Steering Committee For "+/-" Line Indicators: D19385: Improve color use in "[+++- ]" element for colorblind users.
Apr 19 2018, 6:31 PM · Design & Planning, Differential, Plans
epriestley updated the task description for T13127: Plans: Form Steering Committee For "+/-" Line Indicators.
Apr 19 2018, 12:54 AM · Design & Planning, Differential, Plans

Apr 18 2018

epriestley updated the task description for T13127: Plans: Form Steering Committee For "+/-" Line Indicators.
Apr 18 2018, 6:51 AM · Design & Planning, Differential, Plans

Apr 17 2018

epriestley updated the task description for T13127: Plans: Form Steering Committee For "+/-" Line Indicators.
Apr 17 2018, 11:51 PM · Design & Planning, Differential, Plans
epriestley updated the task description for T13127: Plans: Form Steering Committee For "+/-" Line Indicators.
Apr 17 2018, 11:47 PM · Design & Planning, Differential, Plans
epriestley triaged T13127: Plans: Form Steering Committee For "+/-" Line Indicators as Normal priority.
Apr 17 2018, 11:45 PM · Design & Planning, Differential, Plans
epriestley added a subtask for T13105: Plans: Rich presentation and diff rendering pipelines for various file types: T13126: Plans: Diffusion cleanup for document engine.
Apr 17 2018, 10:02 PM · Plans, Files, Differential, Diffusion
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rP665529ab60a1: Restore coverage reporting to Diffusion browse UI.
Apr 17 2018, 9:51 PM · Plans, Files, Differential, Diffusion
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rP21bb0215dbc7: Remove obsoleted "diffusion-browse-file" behavior for coverage.
Apr 17 2018, 9:51 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19378: Restore coverage reporting to Diffusion browse UI.
Apr 17 2018, 1:46 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19377: Remove obsoleted "diffusion-browse-file" behavior for coverage.
Apr 17 2018, 12:54 PM · Plans, Files, Differential, Diffusion

Apr 16 2018

epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

See T13125 for a more detailed breakout of coverage plans.

Apr 16 2018, 12:50 PM · Plans, Files, Differential, Diffusion

Apr 15 2018

epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

This particular page here is fataling:

Apr 15 2018, 5:06 PM · Plans, Files, Differential, Diffusion

Apr 12 2018

epriestley added a comment to T3626: Detection of language for some file types isn't good.

Yeah, this is a combination of a bulk editor bug (which lets you delete task titles) and legacy compatibility code for transaction title rendering (which treats null -> anything transactions as "created this thing.").

Apr 12 2018, 3:30 PM · Customer Impact, Restricted Project, Differential
avivey added a comment to T3626: Detection of language for some file types isn't good.

Oh, good, it's about time this task be created!

Apr 12 2018, 3:04 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T3626: Detection of language for some file types isn't good from to Detection of language for some file types isn't good.
Apr 12 2018, 2:30 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from to In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected.
Apr 12 2018, 2:29 PM · Restricted Project, Differential
epriestley renamed T1101: Allow Show Raw File for updated added files from to Allow Show Raw File for updated added files.
Apr 12 2018, 2:29 PM · Differential
epriestley renamed T3626: Detection of language for some file types isn't good from Detection of language for some file types isn't good to .
Apr 12 2018, 2:28 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected to .
Apr 12 2018, 2:28 PM · Restricted Project, Differential
epriestley renamed T1101: Allow Show Raw File for updated added files from Allow Show Raw File for updated added files to .
Apr 12 2018, 2:28 PM · Differential
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rP37a03402bc44: When following a link to a particular line ("/example.txt$12"), scroll to that….
Apr 12 2018, 12:29 AM · Plans, Files, Differential, Diffusion
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rP5b3a351852a7: Use pseudoelements, not Zero Width Space, to implement copy/paste behavior in….
Apr 12 2018, 12:28 AM · Plans, Files, Differential, Diffusion
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rPc5c53e277a28: Make line selection in source code views less fragile and more consistent.
Apr 12 2018, 12:27 AM · Plans, Files, Differential, Diffusion
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rP55619e89642b: Restore an explicit white background color to files in Paste.
Apr 12 2018, 12:21 AM · Plans, Files, Differential, Diffusion

Apr 11 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19350: When following a link to a particular line ("/example.txt$12"), scroll to that line.
Apr 11 2018, 9:47 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19349: Use pseudoelements, not Zero Width Space, to implement copy/paste behavior in Paste/Diffusion.
Apr 11 2018, 9:30 PM · Plans, Files, Differential, Diffusion