Page MenuHomePhabricator

DifferentialProject
ActivePublic

Details

Description

Differential is a code review tool.

Recent Activity

Yesterday

bcooksley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

In my case (using GMail) it appears to thread properly as well however apparently some clients (KMail) rely on these headers more heavily than others.

Sat, Sep 22, 12:07 AM · Mail, Differential

Fri, Sep 21

epriestley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

In order for threading to work in email clients, the Message-ID header needs to be set on the initial email, with following emails having In-Reply-To / References set to that same Message-ID.

Fri, Sep 21, 11:25 PM · Mail, Differential
epriestley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

I can't reproduce this: mail threads properly in my client.

Fri, Sep 21, 11:23 PM · Mail, Differential
bcooksley created T13204: First mail sent by Differential doesn't have a Message-ID header set properly.
Fri, Sep 21, 10:56 PM · Mail, Differential

Mon, Sep 17

joshuaspence added a revision to T11699: `arc patch` is timing out: D19680: Don't pass `revisionIDs` to `differential.querydiffs`.
Mon, Sep 17, 4:57 AM · Conduit, Differential

Fri, Sep 14

epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Fri, Sep 14, 7:07 PM · Differential, Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Fri, Sep 14, 3:59 PM · Differential, Plans

Wed, Sep 12

epriestley triaged T13200: "Responsible Users" queries with "Author" or "Reviewer" or "Auditor" constraints can include too many results as Low priority.
Wed, Sep 12, 8:18 PM · Diffusion, Differential

Mon, Sep 10

GoogleLegacy added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.
Mon, Sep 10, 9:48 AM · Differential, Audit
GoogleLegacy added a comment to T13057: Formalize "reverts" and "resurrects" between revisions.
Mon, Sep 10, 8:41 AM · Differential

Fri, Sep 7

epriestley closed T8573: All reviewers should be allowed to mark a comment as done, a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
Fri, Sep 7, 6:18 PM · User Delight, Differential
epriestley closed T8573: All reviewers should be allowed to mark a comment as done as Resolved by committing rP2a03367a50c0: When authors add inlines to their own revisions/commits, mark them as "Done" by….
Fri, Sep 7, 6:18 PM · Restricted Project, Differential, Restricted Project
epriestley added a commit to T8573: All reviewers should be allowed to mark a comment as done: rP16a6fc8341ea: Allow reviewers to mark their own inlines as "Done" before they submit them.
Fri, Sep 7, 6:17 PM · Restricted Project, Differential, Restricted Project

Thu, Sep 6

epriestley added a commit to T8573: All reviewers should be allowed to mark a comment as done: rP650e74933abb: Update some inline comment logic to use more modern "Viewer"-oriented….
Thu, Sep 6, 2:57 PM · Restricted Project, Differential, Restricted Project

Tue, Sep 4

epriestley added a comment to T8573: All reviewers should be allowed to mark a comment as done.
  • D19634 allows reviewers to mark their own inlines as "Done" before they submit them. This addresses the case where you want to leave a non-actionable inline (like "This is much-improved.") but feel like leaving an inline like this is imposing on the author because they "must" check it off.
  • D19635 marks the author's own inlines as "Done" by default. They may un-mark them if they prefer (e.g., actually want to leave themselves a TODO). This addresses the case where authors feel like they "must" check off every comment, so they either reply in two passes (one to submit; one to check off all their own replies) or avoid replying.
Tue, Sep 4, 7:16 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T8573: All reviewers should be allowed to mark a comment as done: D19635: When authors add inlines to their own revisions/commits, mark them as "Done" by default.
Tue, Sep 4, 7:08 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T8573: All reviewers should be allowed to mark a comment as done: D19634: Allow reviewers to mark their own inlines as "Done" before they submit them.
Tue, Sep 4, 7:02 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T8573: All reviewers should be allowed to mark a comment as done: D19633: Update some inline comment logic to use more modern "Viewer"-oriented calls/variables.
Tue, Sep 4, 6:31 PM · Restricted Project, Differential, Restricted Project

Mon, Aug 27

epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Mon, Aug 27, 5:23 PM · Differential, Plans

Sat, Aug 25

mribau_a added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@bgamari Did you ever find a solution?

Sat, Aug 25, 5:51 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Aug 24 2018

epriestley added a commit to T13176: Differential now has a "/D123/new/" link: rP5e4d9dfa9219: Condition "Changes Since Last Action" Differential link on "first broadcast"….
Aug 24 2018, 5:04 PM · Differential
epriestley added a revision to T13176: Differential now has a "/D123/new/" link: D19598: Condition "Changes Since Last Action" Differential link on "first broadcast", not "new object".
Aug 24 2018, 4:52 PM · Differential

Aug 14 2018

epriestley added a comment to T13176: Differential now has a "/D123/new/" link.

This is also showing up in initial email, which is silly and pointless.

Aug 14 2018, 9:40 PM · Differential

Aug 10 2018

epriestley closed T12534: Differential still appears in "responsible users" query after resigning as a reviewer as Resolved.

I believe this was fixed by D17558 and discussed in T11050.

Aug 10 2018, 8:00 PM · Bug Report (Needs Information), Differential

Jul 30 2018

epriestley triaged T13176: Differential now has a "/D123/new/" link as Wishlist priority.
Jul 30 2018, 3:03 PM · Differential

Jul 27 2018

epriestley closed T8163: Show changes since last accepted version as Resolved by committing rP9e451879d998: Add a "Changes Since Last Action" view to Differential revisions.
Jul 27 2018, 7:27 PM · Restricted Project, Differential
epriestley added a comment to T8163: Show changes since last accepted version.

I've marked D19541 as resolving this. The change there isn't quite what was asked for here, but overlaps significantly.

Jul 27 2018, 12:10 AM · Restricted Project, Differential
epriestley added a revision to T8163: Show changes since last accepted version: D19541: Add a "Changes Since Last Action" view to Differential revisions.
Jul 27 2018, 12:09 AM · Restricted Project, Differential

Jul 16 2018

epriestley added a comment to T13165: Copy detection in Git is very eager about empty files.

T1022 is possibly somewhat-vaguely-adjacent on symlink stuff.

Jul 16 2018, 11:22 PM · Differential, Arcanist, Git
yelirekim updated subscribers of T13165: Copy detection in Git is very eager about empty files.

@jcox do you know how to reproduce arc diff dying when you try to create certain types of diffs that move or remove symlinks? I think that's adjacent, if not identical to what's being talked about here.

Jul 16 2018, 10:39 PM · Differential, Arcanist, Git

Jul 13 2018

epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Jul 13 2018, 7:10 PM · Differential, Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Jul 13 2018, 6:58 PM · Differential, Plans
epriestley added a comment to T13165: Copy detection in Git is very eager about empty files.

As a special case of this, if you commit an empty a.py file, then add content to it and also add a new empty b.py file in a commit on top of it, the new empty b.py will be detected as a copy of a.py based on the previous (empty) content of the file. I think Git is being pretty reasonable/consistent here, but this is potentially also expectation-defying:

Jul 13 2018, 6:29 PM · Differential, Arcanist, Git
epriestley added a parent task for T13165: Copy detection in Git is very eager about empty files: T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 4:14 PM · Differential, Arcanist, Git
epriestley triaged T13165: Copy detection in Git is very eager about empty files as Wishlist priority.
Jul 13 2018, 4:12 PM · Differential, Arcanist, Git

Jun 22 2018

epriestley renamed T784: Allow Differential changesets to be marked with various attributes from Add more support for folding/ignoring/categorizing changesets from "arc" to Allow Differential changesets to be marked with various attributes.
Jun 22 2018, 3:37 PM · Restricted Project, Restricted Project, Arcanist, Differential
epriestley triaged T13161: Plans: Improve Differential diff display behaviors as Normal priority.
Jun 22 2018, 3:11 PM · Differential, Plans

Jun 1 2018

epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering….
Jun 1 2018, 9:53 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI.
Jun 1 2018, 8:14 PM · Plans, Files, Differential, Diffusion

May 12 2018

Herald updated subscribers of T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
May 12 2018, 2:11 PM · Restricted Project, Audit, Differential

May 9 2018

epriestley closed T1246: Intraline diff bailout at 80 characters is inflexible and undesirable as Resolved by committing rARCa1aec701e3ea: Raise the intraline diff hard limit from 80 to 100 characters.
May 9 2018, 8:38 PM · Differential
epriestley added a comment to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable.

D19442 is marked as fixing this, although it just raises the limit from 80 to 100. This span measures the number of characters between the first changed character and the last changed character (not the total number of characters on the line) and we haven't seen tons of interest in this over the last several years so I think few installs are running into issues with it even at 80. Bumping it to 100 should give us a bit more breathing room but I don't currently plan to make it configurable (see T8227).

May 9 2018, 8:37 PM · Differential
epriestley added a revision to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable: D19442: Raise the intraline diff hard limit from 80 to 100 characters.
May 9 2018, 8:33 PM · Differential

Apr 30 2018

epriestley added a commit to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: rPee32c186dd82: Stop computing ownership for changed paths for Very Large revisions.
Apr 30 2018, 10:44 PM · Plans, Differential
epriestley added a commit to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: rP24305cadb902: Hide the "large" diff warning on "very large" diffs.
Apr 30 2018, 10:33 PM · Plans, Differential
epriestley added a commit to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: rPafc3099ee785: Add a view option to disable blame in Diffusion and fix some view transition….
Apr 30 2018, 10:32 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: D19418: Stop computing ownership for changed paths for Very Large revisions.
Apr 30 2018, 7:15 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: D19416: Hide the "large" diff warning on "very large" diffs.
Apr 30 2018, 6:55 PM · Plans, Differential
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 30 2018, 6:47 PM · Plans, Differential

Apr 28 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19414: Add a view option to disable blame in Diffusion and fix some view transition bugs.
Apr 28 2018, 1:55 PM · Plans, Files, Differential, Diffusion