Page MenuHomePhabricator

DifferentialProject
ActivePublic

Details

Description

Differential is a code review tool.

Recent Activity

Wed, Jan 13

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 9:38 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 9:01 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Wed, Jan 13, 8:33 PM · Accessibility, Differential

Sep 17 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:52 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:38 PM · Differential

Sep 16 2020

epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
Sep 16 2020, 12:44 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21464: Log unexpected exceptions raised by Conduit calls.
Sep 16 2020, 12:24 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21463: When raising a Conduit client exception, show the called method in the error message.
Sep 16 2020, 12:20 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Sep 16 2020, 12:19 AM · Differential
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Sep 16 2020, 12:16 AM · Differential

Sep 8 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21460: When a commit is marked "closeable", clear the "published" flag.
Sep 8 2020, 8:42 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Sep 8 2020, 8:16 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Sep 8 2020, 7:55 PM · Differential

Sep 4 2020

epriestley renamed T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Include "Moved/Copied" gutter in 1-up diffs, and add aural cues to Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Sep 4 2020, 5:56 PM · Accessibility, Differential

Aug 17 2020

epriestley added a parent task for T13521: FormationView could do more Javascript magic around device layouts and header elements: T13574: Make responsive UI elements respond to container width, not window width.
Aug 17 2020, 3:52 PM · Differential

Aug 13 2020

epriestley triaged T13571: When viewing LFS files in Differential or Diffusion, show blob content where reasonable as Normal priority.
Aug 13 2020, 8:12 PM · Diffusion, Differential

Aug 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Aug 12 2020, 9:19 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Aug 12 2020, 8:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21448: Wrap all direct access to author/committer properties on "CommitData".
Aug 12 2020, 7:42 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".
Aug 12 2020, 7:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.
Aug 12 2020, 7:08 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21444: Remove "bin/repository lookup-users" workflow.
Aug 12 2020, 7:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Aug 12 2020, 6:41 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Aug 12 2020, 6:32 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21441: Delete some commit dead parsing code.
Aug 12 2020, 4:31 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21440: Fix some content/background overflow issues with commit graph lists.
Aug 12 2020, 3:54 PM · Differential

Aug 10 2020

epriestley added a project to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: Accessibility.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting as Wishlist priority.
Aug 10 2020, 8:18 PM · Accessibility, Differential

Aug 5 2020

epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
Aug 5 2020, 5:07 PM · Differential

Jul 28 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21431: Improve handle/status list display on devices in commit graph lists.
Jul 28 2020, 6:15 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21430: Improve commit action item layout on mobile.
Jul 28 2020, 5:08 PM · Differential

Jul 17 2020

epriestley added a revision to T2495: Improve whitespace expansion of tab literals: D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Jul 17 2020, 10:07 PM · Restricted Project, FreeBSD, Diffusion, Differential

Jul 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21418: Improve desktop and mobile layouts for new "CommitGridView".
Jul 12 2020, 9:26 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Jul 12 2020, 7:45 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21416: Clean up some minor commit list CSS.
Jul 12 2020, 6:03 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21415: Remove "PhabricatorAuditListView".
Jul 12 2020, 5:44 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Jul 12 2020, 4:25 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Jul 12 2020, 4:16 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Jul 12 2020, 3:41 PM · Differential

Jul 10 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21411: Improve rendering of history graph in "CommitGraphView".
Jul 10 2020, 6:44 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Jul 10 2020, 6:20 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21409: Remove the "Graph" view as a dedicated repository view.
Jul 10 2020, 5:56 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21408: Remove "Recent Commits" from repository landing page.
Jul 10 2020, 5:48 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21407: Remove "DiffusionTagTableView".
Jul 10 2020, 4:25 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21406: Remove the "authored" subheader from commits.
Jul 10 2020, 4:20 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21405: Modernize "Author" and "Committer" rendering for commits.
Jul 10 2020, 4:16 PM · Differential
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

The broader structural issue here is:

Jul 10 2020, 4:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Jul 10 2020, 4:05 PM · Differential

Jul 9 2020

epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

A second issue is that some of the "publish" behavior depends on the commit/revision relationship. This can still be sequenced correctly entirely in the publish daemon, but "close related revisions" and "publish the commit" are not entirely independent.

Jul 9 2020, 10:24 PM · Differential
epriestley triaged T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Normal priority.
Jul 9 2020, 10:13 PM · Differential