Page MenuHomePhabricator

Correct minor "jump to symbol" behavior in Differential
ClosedPublic

Authored by epriestley on Mar 17 2021, 10:30 PM.
Tags
None
Referenced Files
F18104692: D21641.id51506.diff
Sun, Aug 10, 1:37 PM
F18104691: D21641.id51505.diff
Sun, Aug 10, 1:37 PM
F18104690: D21641.id.diff
Sun, Aug 10, 1:37 PM
F18100326: D21641.diff
Sat, Aug 9, 11:49 AM
F18084133: D21641.id51506.diff
Tue, Aug 5, 1:52 PM
F17942032: D21641.id.diff
Thu, Jul 31, 6:10 AM
F17931130: D21641.id51506.diff
Wed, Jul 30, 6:39 PM
F17931092: D21641.diff
Wed, Jul 30, 6:36 PM
Subscribers
None

Details

Summary

Ref T13644. Ref T13638.

  • Double-encode the symbol that is used as a path component, similar to Diffusion.
  • Fix an outdated reference to ".path", which provided context for symbol lookup.
  • Prevent command-clicking headers from looking up the path as a symbol.
Test Plan
  • Command-clicked headers, no longer got a symbol.
  • Command-clicked stuff with "/", saw it double-encoded and decoded properly.
  • Command-clicked normal symbols, saw "path" populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 10:31 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.