Page MenuHomePhabricator

Correct minor "jump to symbol" behavior in Differential
ClosedPublic

Authored by epriestley on Mar 17 2021, 10:30 PM.
Tags
None
Referenced Files
F14078006: D21641.diff
Fri, Nov 22, 1:43 AM
Unknown Object (File)
Mon, Nov 18, 11:21 PM
Unknown Object (File)
Thu, Nov 14, 5:31 PM
Unknown Object (File)
Mon, Nov 11, 1:12 PM
Unknown Object (File)
Thu, Nov 7, 2:28 PM
Unknown Object (File)
Mon, Nov 4, 8:10 PM
Unknown Object (File)
Thu, Oct 24, 9:26 PM
Unknown Object (File)
Oct 22 2024, 8:49 PM
Subscribers
None

Details

Summary

Ref T13644. Ref T13638.

  • Double-encode the symbol that is used as a path component, similar to Diffusion.
  • Fix an outdated reference to ".path", which provided context for symbol lookup.
  • Prevent command-clicking headers from looking up the path as a symbol.
Test Plan
  • Command-clicked headers, no longer got a symbol.
  • Command-clicked stuff with "/", saw it double-encoded and decoded properly.
  • Command-clicked normal symbols, saw "path" populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 10:31 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.