Page MenuHomePhabricator

Correct minor "jump to symbol" behavior in Differential
ClosedPublic

Authored by epriestley on Wed, Mar 17, 10:30 PM.

Details

Summary

Ref T13644. Ref T13638.

  • Double-encode the symbol that is used as a path component, similar to Diffusion.
  • Fix an outdated reference to ".path", which provided context for symbol lookup.
  • Prevent command-clicking headers from looking up the path as a symbol.
Test Plan
  • Command-clicked headers, no longer got a symbol.
  • Command-clicked stuff with "/", saw it double-encoded and decoded properly.
  • Command-clicked normal symbols, saw "path" populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Mar 17, 10:31 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.