Page MenuHomePhabricator

Correct minor "jump to symbol" behavior in Differential
ClosedPublic

Authored by epriestley on Mar 17 2021, 10:30 PM.
Tags
None
Referenced Files
F18876816: D21641.id.diff
Thu, Nov 6, 3:49 AM
F18803168: D21641.id51505.diff
Oct 17 2025, 9:55 PM
F18756857: D21641.diff
Oct 5 2025, 1:59 PM
F18724744: D21641.id.diff
Sep 30 2025, 3:59 AM
F18719413: D21641.diff
Sep 29 2025, 5:07 PM
F18571860: D21641.id51506.diff
Sep 10 2025, 5:26 AM
F18571859: D21641.id51505.diff
Sep 10 2025, 5:26 AM
F18104692: D21641.id51506.diff
Aug 10 2025, 1:37 PM
Subscribers
None

Details

Summary

Ref T13644. Ref T13638.

  • Double-encode the symbol that is used as a path component, similar to Diffusion.
  • Fix an outdated reference to ".path", which provided context for symbol lookup.
  • Prevent command-clicking headers from looking up the path as a symbol.
Test Plan
  • Command-clicked headers, no longer got a symbol.
  • Command-clicked stuff with "/", saw it double-encoded and decoded properly.
  • Command-clicked normal symbols, saw "path" populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 10:31 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.