Page MenuHomePhabricator

Correct minor "jump to symbol" behavior in Differential
ClosedPublic

Authored by epriestley on Mar 17 2021, 10:30 PM.
Tags
None
Referenced Files
F17712106: D21641.diff
Thu, Jul 17, 9:24 AM
Unknown Object (File)
Mon, Jul 7, 1:41 PM
Unknown Object (File)
May 6 2025, 6:15 PM
Unknown Object (File)
May 2 2025, 3:12 AM
Unknown Object (File)
Apr 29 2025, 3:42 AM
Unknown Object (File)
Apr 29 2025, 12:51 AM
Unknown Object (File)
Apr 25 2025, 4:29 PM
Unknown Object (File)
Apr 18 2025, 4:55 AM
Subscribers
None

Details

Summary

Ref T13644. Ref T13638.

  • Double-encode the symbol that is used as a path component, similar to Diffusion.
  • Fix an outdated reference to ".path", which provided context for symbol lookup.
  • Prevent command-clicking headers from looking up the path as a symbol.
Test Plan
  • Command-clicked headers, no longer got a symbol.
  • Command-clicked stuff with "/", saw it double-encoded and decoded properly.
  • Command-clicked normal symbols, saw "path" populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 10:31 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.