Page MenuHomePhabricator

Lint star colors have different meaning for revisions and diffs
Closed, ResolvedPublic

Description

If the lint results for a revision are OK, a green star is shown. If there are warnings, the star is yellow:

pasted_file (107×396 px, 13 KB)

However, looking at the results for the diffs themselves the colors are different. Red now means warnings and yellow is OK:

pasted_file (136×351 px, 11 KB)

pasted_file (189×283 px, 13 KB)

Related Objects

Event Timeline

ivo updated the task description. (Show Details)
ivo added a project: Differential.
ivo added a subscriber: ivo.
eadler added a project: Restricted Project.Jan 11 2016, 9:39 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 11 2016, 9:42 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:10 PM
epriestley claimed this task.
  • Colors are now consistent.
  • Icons no longer use only color to communicate information.
  • Icons are (mostly) consistent with the Harbormaster icons that have similar meanings.
  • See ConfigModules/ExtensionsConstants: Differential.

Screen Shot 2021-03-17 at 1.44.04 PM.png (627×427 px, 45 KB)