Lint star colors have different meaning for revisions and diffs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ivo
	Nov 11 2015, 3:36 PM

Description

If the lint results for a revision are OK, a green star is shown. If there are warnings, the star is yellow:

However, looking at the results for the diffs themselves the colors are different. Red now means warnings and yellow is OK:

	Restricted Differential Revision	Restricted Diffusion Commit
	Restricted Differential Revision	Restricted Diffusion Commit

ivo updated the task description. (Show Details)

ivo added a project: Differential.

ivo added a subscriber: ivo.

eadler added a project: Restricted Project.Jan 11 2016, 9:39 PM

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 11 2016, 9:42 PM

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:10 PM

See also PHI1910.

epriestley added a revision: Restricted Differential Revision.Mar 17 2021, 8:26 PM

epriestley added a revision: Restricted Differential Revision.Mar 17 2021, 8:43 PM

Colors are now consistent.
Icons no longer use only color to communicate information.
Icons are (mostly) consistent with the Harbormaster icons that have similar meanings.
See Config → Modules/Extensions → Constants: Differential.

epriestley added a commit: Restricted Diffusion Commit.Mar 17 2021, 8:45 PM

epriestley added a commit: Restricted Diffusion Commit.

	F8545728: Screen Shot 2021-03-17 at 1.44.04 PM.png
	Mar 17 2021, 8:45 PM