Page MenuHomePhabricator
Create Task
Maniphest T9764

Lint star colors have different meaning for revisions and diffs
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
ivo
Nov 11 2015, 3:36 PM
Tags
Attached Files
F8545728: Screen Shot 2021-03-17 at 1.44.04 PM.png
Mar 17 2021, 8:45 PM
F961130: pasted_file
Nov 11 2015, 3:36 PM
F961127: pasted_file
Nov 11 2015, 3:36 PM
F961122: pasted_file
Nov 11 2015, 3:36 PM
Subscribers
eadler
epriestley
ivo
joshuaspence

Description

If the lint results for a revision are OK, a green star is shown. If there are warnings, the star is yellow:

pasted_file (107×396 px, 13 KB)

However, looking at the results for the diffs themselves the colors are different. Red now means warnings and yellow is OK:

pasted_file (136×351 px, 11 KB)

pasted_file (189×283 px, 13 KB)

Revisions and Commits

rP Phabricator
D21639rP527dd3ce50b2 Replace Differential "unit stars" with icons
D21640rPd6ed9392d4e0 Replace Differential "lint stars" with icons

Related Objects

Mentioned In
Z1336: General Chat

Event Timeline

ivo created this task.Nov 11 2015, 3:36 PM
ivo updated the task description. (Show Details)
ivo added a project: Differential.
ivo added a subscriber: ivo.
joshuaspence added a subscriber: joshuaspence.Nov 11 2015, 7:18 PM
eadler added a project: Restricted Project.Jan 11 2016, 9:39 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 11 2016, 9:42 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:10 PM
Herald added a subscriber: eadler. · View Herald TranscriptJul 4 2016, 9:10 PM
danielberger mentioned this in Z1336: General Chat.Oct 5 2017, 1:27 PM
epriestley moved this task from Backlog to Next on the Differential board.Mar 17 2021, 7:03 PM
epriestley added a subscriber: epriestley.Mar 17 2021, 7:06 PM

See also PHI1910.

epriestley added a revision: D21639: Replace Differential "unit stars" with icons.Mar 17 2021, 8:26 PM
epriestley added a revision: D21640: Replace Differential "lint stars" with icons.Mar 17 2021, 8:43 PM
epriestley closed this task as Resolved.Mar 17 2021, 8:45 PM
epriestley claimed this task.
  • Colors are now consistent.
  • Icons no longer use only color to communicate information.
  • Icons are (mostly) consistent with the Harbormaster icons that have similar meanings.
  • See Config → Modules/Extensions → Constants: Differential.

Screen Shot 2021-03-17 at 1.44.04 PM.png (627×427 px, 45 KB)

epriestley added a commit: rPd6ed9392d4e0: Replace Differential "lint stars" with icons.Mar 17 2021, 8:45 PM
epriestley added a commit: rP527dd3ce50b2: Replace Differential "unit stars" with icons.
Phabricator · Built by Phacility