Page MenuHomePhabricator
Differential D21651

On inline comments, track an explicit "committed" content state
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 9:05 PM.
Tags
None
Referenced Files
F17413833: D21651.diff
Sun, Jun 29, 5:24 PM
Unknown Object (File)
Tue, Jun 17, 9:06 AM
Unknown Object (File)
Sun, Jun 1, 10:59 AM
Unknown Object (File)
Sat, May 31, 6:22 PM
Unknown Object (File)
May 28 2025, 9:37 AM
Unknown Object (File)
May 27 2025, 5:30 PM
Unknown Object (File)
Apr 30 2025, 10:55 AM
Unknown Object (File)
Apr 29 2025, 6:13 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits
rP5efe7fb4c181: On inline comments, track an explicit "committed" content state
Summary

Ref T13559. To allow the client to make correct decisions about what buttons mean, track an explicit "Committed" content state.

This is the last version of the comment that has been saved on the server, and does not exist if the comment has never been saved.

Test Plan

Created comments, etc. See followups.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 25 2021, 9:05 PM
Harbormaster completed remote builds in B25328: Diff 51520.Mar 25 2021, 9:06 PM
epriestley requested review of this revision.Mar 25 2021, 9:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:01 PM
Closed by commit rP5efe7fb4c181: On inline comments, track an explicit "committed" content state (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5efe7fb4c181: On inline comments, track an explicit "committed" content state.

Revision Contents
Changeset List

PathSize
resources/
celerity/
webroot/
rsrc/
externals/
javelin/
lib/
4 lines
js/
application/
diff/
32 lines

Diff 51547

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Resource.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility