Page MenuHomePhabricator

Fix an issue where inlines could be duplicated in the client list
ClosedPublic

Authored by epriestley on Mar 18 2021, 6:33 PM.
Tags
None
Referenced Files
F18782690: D21642.id51508.diff
Mon, Oct 13, 2:21 AM
F18759825: D21642.id.diff
Mon, Oct 6, 6:05 AM
F18670711: D21642.diff
Thu, Sep 25, 1:12 AM
F18634338: D21642.id51540.diff
Tue, Sep 16, 10:11 PM
F18618869: D21642.id51508.diff
Sep 15 2025, 1:08 AM
F18602399: D21642.id.diff
Sep 13 2025, 3:00 PM
F18571864: D21642.id51540.diff
Sep 10 2025, 5:26 AM
F18571863: D21642.id51508.diff
Sep 10 2025, 5:26 AM
Subscribers
None

Details

Summary

Ref T13559. D21261 added caching here, but the logic in rebuilding inlines wasn't quite correct, and could lead to us double-appending.

Instead, when rebuilding, unconditionally discard the old list.

Test Plan
  • Added inline comments to a file in Differential.
  • Marked some done.
  • Scrolled so the inline comment header was visible, saw "X / Y Comments" button in header.
  • Clicked "Show 20 more lines" on the changeset with inlines (or toggle "View Unified" / "View Side-by-Side", or other interactions likely work too).
    • Before: saw "X / Y" change improperly (because inlines in that file were double-counted).
    • After: saw stable count.
  • Grepped for "differential-inline-comment-refresh", got no hits, concluded this event has no listeners.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable