Page MenuHomePhabricator

Fix an issue where inlines could be duplicated in the client list
ClosedPublic

Authored by epriestley on Mar 18 2021, 6:33 PM.
Tags
None
Referenced Files
F14060280: D21642.diff
Mon, Nov 18, 12:17 AM
F14049106: D21642.diff
Thu, Nov 14, 10:57 AM
F14037386: D21642.diff
Sun, Nov 10, 3:33 PM
F14029235: D21642.id51540.diff
Fri, Nov 8, 8:12 PM
F14019920: D21642.diff
Tue, Nov 5, 11:47 PM
F14010017: D21642.id51540.diff
Thu, Oct 31, 3:08 AM
F14009938: D21642.diff
Thu, Oct 31, 2:06 AM
F13995439: D21642.id51540.diff
Wed, Oct 23, 12:53 PM
Subscribers
None

Details

Summary

Ref T13559. D21261 added caching here, but the logic in rebuilding inlines wasn't quite correct, and could lead to us double-appending.

Instead, when rebuilding, unconditionally discard the old list.

Test Plan
  • Added inline comments to a file in Differential.
  • Marked some done.
  • Scrolled so the inline comment header was visible, saw "X / Y Comments" button in header.
  • Clicked "Show 20 more lines" on the changeset with inlines (or toggle "View Unified" / "View Side-by-Side", or other interactions likely work too).
    • Before: saw "X / Y" change improperly (because inlines in that file were double-counted).
    • After: saw stable count.
  • Grepped for "differential-inline-comment-refresh", got no hits, concluded this event has no listeners.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable