Page MenuHomePhabricator
Differential D21639

Replace Differential "unit stars" with icons
ClosedPublic
Actions

Authored by epriestley on Mar 17 2021, 8:26 PM.
Tags
None
Referenced Files
F18785901: D21639.id.diff
Tue, Oct 14, 2:33 PM
F18784233: D21639.diff
Mon, Oct 13, 12:09 PM
F18763395: D21639.id51501.diff
Tue, Oct 7, 12:01 AM
F18757374: D21639.id.diff
Sun, Oct 5, 5:11 PM
F18755122: D21639.id51504.diff
Sun, Oct 5, 3:55 AM
F18648142: D21639.id51501.diff
Fri, Sep 19, 3:44 PM
F18593349: D21639.id.diff
Sep 12 2025, 2:42 PM
F18584197: D21639.diff
Sep 11 2025, 12:17 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T9764: Lint star colors have different meaning for revisions and diffs
Commits
rP527dd3ce50b2: Replace Differential "unit stars" with icons
Summary

Ref T9764. These "star" icons are unclear, inconsistent, and not friendly to colorblind users.

They date from a time long ago when the product didn't have icons.

Modernize them and make them more consistent with the similar statuses in Harbormaster.

Test Plan

Screen Shot 2021-03-17 at 1.24.47 PM.png (164×217 px, 6 KB)

Screen Shot 2021-03-17 at 1.24.18 PM.png (389×1 px, 37 KB)

Screen Shot 2021-03-17 at 1.24.40 PM.png (61×244 px, 4 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 17 2021, 8:26 PM
Harbormaster completed remote builds in B25309: Diff 51501.Mar 17 2021, 8:27 PM
epriestley requested review of this revision.Mar 17 2021, 8:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 8:46 PM
Closed by commit rP527dd3ce50b2: Replace Differential "unit stars" with icons (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP527dd3ce50b2: Replace Differential "unit stars" with icons.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
module/
6 lines
differential/
constants/
144 lines
81 lines
customfield/
23 lines
view/
54 lines
view/
phui/
13 lines

Diff 51504

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/module/PhabricatorConfigModuleController.php

Loading...
View Options

src/applications/differential/constants/DifferentialConstantsModule.php

Loading...
View Options

src/applications/differential/constants/DifferentialUnitStatus.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
View Options

src/view/phui/PHUIColor.php

Loading...
Phabricator · Built by Phacility