Page MenuHomePhabricator

Remove direct reads of form state from main Inline client code
ClosedPublic

Authored by epriestley on Mar 25 2021, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 21, 6:28 AM
Unknown Object (File)
Wed, Feb 21, 6:28 AM
Unknown Object (File)
Wed, Feb 21, 6:28 AM
Unknown Object (File)
Feb 4 2024, 12:56 AM
Unknown Object (File)
Jan 29 2024, 8:22 PM
Unknown Object (File)
Jan 26 2024, 12:55 PM
Unknown Object (File)
Dec 27 2023, 8:51 PM
Unknown Object (File)
Dec 21 2023, 12:50 PM
Subscribers
None

Details

Summary

Ref T13559. Instead of directly reading form state, make all callers use the "active" state instead. The state reads the form.

No functional changes, just clarifying responsiblites.

Test Plan

Created inlines, etc. See followup changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.