Remove direct reads of form state from main Inline client code
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 8:56 PM.

Tags

None

Referenced Files

	F18805689: D21647.diff
	Sat, Oct 18, 4:09 PM

	F18802875: D21647.id51516.diff
	Fri, Oct 17, 8:44 PM

	F18802872: D21647.id51537.diff
	Fri, Oct 17, 8:44 PM

	F18794299: D21647.diff
	Thu, Oct 16, 11:23 PM

	F18791574: D21647.diff
	Thu, Oct 16, 3:23 PM

	F18715305: D21647.id51516.diff
	Sep 29 2025, 9:51 AM

	F18711009: D21647.id51537.diff
	Sep 29 2025, 3:32 AM

	F18695673: D21647.diff
	Sep 27 2025, 6:17 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits: rP0f04d9e58458: Remove direct reads of form state from main Inline client code

Summary

Ref T13559. Instead of directly reading form state, make all callers use the "active" state instead. The state reads the form.

No functional changes, just clarifying responsiblites.

Test Plan

Created inlines, etc. See followup changes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 25 2021, 8:56 PM

Harbormaster completed remote builds in B25324: Diff 51516.Mar 25 2021, 8:57 PM

epriestley requested review of this revision.Mar 25 2021, 8:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM

Closed by commit rP0f04d9e58458: Remove direct reads of form state from main Inline client code (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0f04d9e58458: Remove direct reads of form state from main Inline client code.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

28 lines

Diff 51537

View Options

resources/celerity/map.php