Page MenuHomePhabricator

Make the client authoritative for "Cancel" actions
ClosedPublic

Authored by epriestley on Mar 25 2021, 9:00 PM.
Tags
None
Referenced Files
F18767103: D21649.diff
Tue, Oct 7, 8:36 PM
F18753179: D21649.diff
Sat, Oct 4, 5:44 PM
F18734411: D21649.id.diff
Tue, Sep 30, 10:53 PM
F18693055: D21649.id51542.diff
Sat, Sep 27, 12:04 AM
F18671917: D21649.id.diff
Thu, Sep 25, 5:53 AM
F18594837: D21649.id.diff
Sep 12 2025, 7:31 PM
F18586483: D21649.diff
Sep 11 2025, 6:46 PM
F18571884: D21649.id51542.diff
Sep 10 2025, 5:27 AM
Subscribers
None

Details

Summary

Ref T13559. When the user clicks the "Cancel" button, we sometimes take it to mean "delete" (when the comment is empty).

Both the client and server make a decision about this, and they may not agree, which causes the client to fall out of sync.

Make the client responsible for deciding whether it wants to interpret a click on the "Cancel" button as a "revert" or a "delete".

Test Plan

Cancelled empty and nonempty comments, etc. See followup changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.