Page MenuHomePhabricator
Create Task
Maniphest T13643

Permissions and UI around manual web "Update Diff" workflow are inconsistent
Open, WishlistPublic
Actions

Description

The manual web "Update Diff" workflow is available to anyone who can edit the revision, but if you click it on a revision you aren't the author if, the UI won't let you attach it to the revision you selected. You still can attach it if you "hack" the HTML form.

This should probably be made more consistent. For example:

  • Disable the action for non-authors, roadblock with an error dialog suggesting "Commandeer".
  • Keep the action enabled, but ask non-authors to confirm that they want to commandeer. Commandeer if they update.

Related Objects

Event Timeline

epriestley renamed this task from Permissions around manual web "Update Diff" workflow are inconsistent to Permissions and UI around manual web "Update Diff" workflow are inconsistent.Mar 17 2021, 7:22 PM
epriestley triaged this task as Wishlist priority.
epriestley created this task.
epriestley moved this task from Backlog to Future Work on the Differential board.
epriestley mentioned this in T9499: Revision repository is not updated when it is changed in the UI.
Phabricator · Built by Phacility