Page MenuHomePhabricator

ptarjan (Paul Tarjan)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2011, 11:09 AM (489 w, 6 d)
Availability
Available

Recent Activity

Thu, Jun 25

ptarjan accepted D21355: Add more "RepositoryRef" legacy status mappings.
Thu, Jun 25, 12:05 AM

Apr 30 2020

ptarjan added a comment to D21192: Restore the ":(attr:filter=lfs)" test for LFS.

Thanks so much for fixing this!

Apr 30 2020, 5:57 PM
ptarjan added a comment to D21190: Detect LFS by looking for tracks in ".gitattributes" instead of using "ls-tree".

Thanks for the heads up. Indeed this will break us (if I'm reading this right). .gitattributes is not required to be at the root level and we actually don't have one there, we put it in lots of subdirectories. Can you do a find or something like that? And not every one of our .gitattributes will contain lfs files so I guess you have to cat them all and return true if any have it?.

Apr 30 2020, 12:33 AM

Mar 25 2020

ptarjan committed rARC33b9728b5f65: Run ls-files from the root of the directory (authored by ptarjan).
Run ls-files from the root of the directory
Mar 25 2020, 9:24 PM
ptarjan closed D21045: Run ls-files from the root of the directory.
Mar 25 2020, 9:24 PM
ptarjan updated the summary of D21045: Run ls-files from the root of the directory.
Mar 25 2020, 9:13 PM
ptarjan updated the summary of D21045: Run ls-files from the root of the directory.
Mar 25 2020, 9:13 PM
ptarjan updated the summary of D21045: Run ls-files from the root of the directory.
Mar 25 2020, 9:12 PM
ptarjan updated the diff for D21045: Run ls-files from the root of the directory.

use repository api

Mar 25 2020, 9:06 PM
ptarjan requested review of D21045: Run ls-files from the root of the directory.
Mar 25 2020, 8:45 PM

Mar 20 2020

ptarjan committed rARC97e050fce7a5: Use a named remote and branches for staging to help git-lfs (authored by ptarjan).
Use a named remote and branches for staging to help git-lfs
Mar 20 2020, 6:57 PM
ptarjan closed D21041: Use a named remote and branches for staging to help git-lfs.
Mar 20 2020, 6:57 PM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • code review
Mar 20 2020, 6:44 PM
ptarjan added a comment to D21041: Use a named remote and branches for staging to help git-lfs.

Thanks for the code review and archeology! I did some archeology on our end and indeed, it was removed on Sep 26, 2018 when we forked this diff workflow for exactly the reason in this diff. With the --no-verify the LFS objects were not being pushed to our staging repo, so our Jenkins jobs wouldn't have them and would fail. So I do think this the right fix :)

Mar 20 2020, 3:56 PM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • oops wrong way
Mar 20 2020, 1:01 AM
ptarjan added a comment to D21041: Use a named remote and branches for staging to help git-lfs.

Nice find! I see there is already a --no-verify in this upstream version but we didn't have it in ours... maybe because of the lfs version? So maybe this diff is actually improving the life of lfs folks?

Mar 20 2020, 1:00 AM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • go with --no-verify
Mar 20 2020, 12:59 AM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • Revert "only run fetch if git for-each-ref is empty"
  • Revert "fix spelling"
  • Revert "handle the case where you need to remove it before adding it"
  • Revert "Use a named remote and branches for staging to help git-lfs"
  • try the double push thing for lfs repos
Mar 20 2020, 12:42 AM
ptarjan added a comment to D21041: Use a named remote and branches for staging to help git-lfs.

Thanks Evan! I tried what you suggested but I think GIT_LFS_SKIP_SMUDGE=1 is only for pulling not pushing, since the first push in your suggestion is still uploading to LFS and their code doesn't seem to refer to that env var https://github.com/git-lfs/git-lfs/blob/5f969e6a3e48ecee48b6235adccc42a644e82101/commands/command_push.go, I can't really see any way to disable lfs other than git lfs uninstall; git push; git lfs install. Is that nuts?

Mar 20 2020, 12:28 AM

Mar 19 2020

ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • only run fetch if git for-each-ref is empty
Mar 19 2020, 9:59 PM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • fix spelling
Mar 19 2020, 6:41 PM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.
  • handle the case where you need to remove it before adding it
Mar 19 2020, 6:38 PM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.

try again with the remote removed from the failure before

Mar 19 2020, 6:33 PM
ptarjan updated the diff for D21041: Use a named remote and branches for staging to help git-lfs.

try again now that I put in my ssh key

Mar 19 2020, 6:33 PM
ptarjan requested review of D21041: Use a named remote and branches for staging to help git-lfs.
Mar 19 2020, 6:29 PM

Jun 9 2015

ptarjan added a comment to D11384: Add a recommendation for the amount of RAM required to run Phabricator.

@epriestley is a t2.micro enough to handle phabricator for say 10 users (small startup)? What's the tipping point (concurrent requests I'm assuming not DB size for extra users)?

Jun 9 2015, 7:05 PM

Sep 30 2014

ptarjan added a comment to P1098 (An Untitled Masterwork).

How did you fix this problem?

Sep 30 2014, 9:54 PM

Sep 22 2014

ptarjan created T6157: Failing to parse patch with binary delta.
Sep 22 2014, 9:52 AM · Arcanist

Mar 22 2014

ptarjan added a comment to T4662: Make arc look for .arcconfig in non-root directories.

@epriestley I'm totally with you, we don't want any special casing for Facebook. I was just hoping others could benefit from this as well.

Mar 22 2014, 5:39 AM · Arcanist
ptarjan updated subscribers of T4662: Make arc look for .arcconfig in non-root directories.
Mar 22 2014, 4:03 AM · Arcanist