Page MenuHomePhabricator

Fix "undefined index" error in Differential changeset parser
AbandonedPublic

Authored by epriestley on Jul 31 2017, 7:56 AM.
Tags
None
Referenced Files
F15590557: D18302.id.diff
Fri, May 9, 8:08 PM
F15590424: D18302.id44009.diff
Fri, May 9, 7:21 PM
F15528138: D18302.id44009.diff
Tue, Apr 22, 9:20 AM
F15487736: D18302.id44009.diff
Thu, Apr 10, 4:42 PM
F15482530: D18302.id.diff
Apr 9 2025, 6:04 AM
F15479452: D18302.diff
Apr 8 2025, 7:22 AM
F15382665: D18302.diff
Mar 14 2025, 1:43 PM
Unknown Object (File)
Feb 20 2025, 10:21 PM
Subscribers

Details

Summary

Fixes T8591. It seems that this error occurs when a changeset has a synthetic comment linked to a line number that doesn't exist.

Test Plan

Added a test case, which failed with an "undefined index" error before this patch.

Diff Detail

Repository
rP Phabricator
Branch
changeset
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17847
Build 23970: Run Core Tests
Build 23969: arc lint + arc unit