Page MenuHomePhabricator

Fix "undefined index" error in Differential changeset parser
AbandonedPublic

Authored by epriestley on Jul 31 2017, 7:56 AM.
Tags
None
Referenced Files
F19504500: D18302.diff
Fri, Jan 9, 5:14 AM
F19504451: D18302.diff
Fri, Jan 9, 5:11 AM
F19467936: D18302.diff
Sat, Jan 3, 8:04 PM
F19037339: D18302.id.diff
Nov 25 2025, 11:07 PM
F18920283: D18302.id44009.diff
Nov 9 2025, 12:50 PM
F18914983: D18302.id44009.diff
Nov 9 2025, 7:23 AM
F18877026: D18302.id.diff
Nov 6 2025, 5:34 AM
F18872895: D18302.diff
Nov 5 2025, 6:47 AM
Subscribers

Details

Summary

Fixes T8591. It seems that this error occurs when a changeset has a synthetic comment linked to a line number that doesn't exist.

Test Plan

Added a test case, which failed with an "undefined index" error before this patch.

Diff Detail

Repository
rP Phabricator
Branch
changeset
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17847
Build 23970: Run Core Tests
Build 23969: arc lint + arc unit