Page MenuHomePhabricator

Fix "undefined index" error in Differential changeset parser
AbandonedPublic

Authored by epriestley on Jul 31 2017, 7:56 AM.
Tags
None
Referenced Files
F14148111: D18302.diff
Wed, Dec 4, 9:05 AM
Unknown Object (File)
Wed, Nov 27, 7:27 AM
Unknown Object (File)
Mon, Nov 25, 4:57 PM
Unknown Object (File)
Wed, Nov 20, 4:20 AM
Unknown Object (File)
Sat, Nov 16, 7:06 AM
Unknown Object (File)
Tue, Nov 12, 12:02 PM
Unknown Object (File)
Sat, Nov 9, 2:25 PM
Unknown Object (File)
Fri, Nov 8, 3:59 AM
Subscribers

Details

Summary

Fixes T8591. It seems that this error occurs when a changeset has a synthetic comment linked to a line number that doesn't exist.

Test Plan

Added a test case, which failed with an "undefined index" error before this patch.

Diff Detail

Repository
rP Phabricator
Branch
changeset
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17847
Build 23970: Run Core Tests
Build 23969: arc lint + arc unit