Page MenuHomePhabricator

Fix an issue when undoing mutiple inline comment deletions
ClosedPublic

Authored by epriestley on Mar 25 2021, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 6, 5:36 AM
Unknown Object (File)
Wed, Feb 21, 6:29 AM
Unknown Object (File)
Wed, Feb 21, 6:28 AM
Unknown Object (File)
Wed, Feb 21, 6:28 AM
Unknown Object (File)
Feb 4 2024, 12:57 AM
Unknown Object (File)
Feb 2 2024, 9:15 AM
Unknown Object (File)
Jan 31 2024, 8:49 AM
Unknown Object (File)
Jan 19 2024, 6:50 PM
Subscribers
None

Details

Summary

Ref T13559. If you create comments A and B, then delete comments A and B, then undo the deletion of A, the UI undoes the deletion of B instead.

This is becasue the undo rows are shipped down with a static scalar metadata reference. When copied multiple times to create multiple undo rows, they reference the same data object.

Preventing this in the general case is a problem with greater scope. For now, just avoid rendering these rows with any metadata so they don't alias a single data object.

Test Plan
  • Created comments A, B.
  • Deleted comments A, B.
  • Clicked "Undo" on A.
    • Before: Deletion of "B" undone.
    • After: Deletion of "A" undone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable