At Facebook we have a custom arcanist lint engine that wraps eslint with a custom (JS) runner that extracts more info about each fix:

@ablekh Have you tried Googling for "how to update phabricator"?

<3 thanks

Oops, thanks.

Will do – my branches are usually set up right though so I very rarely see that prompt.

I don't think expecting people to hit enter is entirely reasonable – I'm personally scared that it'll submit the form, which is what enter ordinarily does in a form (except in a textarea).

@csilvers I must have been unclear when suggesting this to you, sorry… Phabricator has this feature at /calendar/, we just don't have a sync script for it!

Correct.

A "rescind rejection" would also help me, which might or might not be simpler than soft rejection (but doesn't help the blocking reviewers case which I've also seen here).

My Phabricator workflow is essentially completely via email and I believe many of my coworkers work the same way (and @epriestley as well, last I heard).

Thanks.

React (https://github.com/facebook/react) currently uses GitHub pull requests for external contributions, but all committers (myself included) dislike GitHub as a mechanism for code review and would strongly prefer to use Phabricator. Like most open-source projects, we're interested in reducing the friction of making a one-off code contribution; we use GitHub because most people are familar with the process of making a pull request.

(Calling user.query with a username appears to do the right thing…)

Oops, don't allow newlines in non-triple-quoted strings

Sorry if I was unclear -- that paste is the result of running without your new patch so it should still be slow (but isn't). Is it easy to make it redo the work? Running with --change (again, without D9178) completes quickly and gets rid of the "Still importing..." message.

The file itself certainly does:

yay for catching things. also caching stuff.

When viewing a URI like /D123, we'll generate links to, e.g,, /D123#inline-456 to avoid reloading the page. These will eventually expire when a diff is updated. Instead, the client and server can coordinate to figure out where the inline actually is and load that instead.

long live Clowncopterize.

:)

Suuure.

I tested it with a real, live IE8 browser in "IE8 Standards" mode.

Make it actually work and test it

Consistent clowny copying

(Facebook's toArray corroborates this story: https://github.com/facebook/react/blob/master/src/vendor/core/toArray.js says "IE < 9 does not support Array#slice on collections objects".)

Closed by commit rPa7272dfb03d0.

Oops, sorry for mixing up the task IDs.

I got confused by this a couple days ago too.

Remove casts

Well, you can have overlapping comment ranges, right? So I could have four comments like:

Fix images, remove extraneous classes, fix copying out of pastes

I can't reproduce the tab problem in Chrome beta on OS X and I don't have Chromium on Ubuntu handy, but hopefully nothing will break terribly there.

Well, this only changes the behavior in the case of a single word that's wider than the diff window; if it can avoid breaking a word by wrapping it still will. Does your text editor not do the same? I just tested in vim, emacs, TextMate, and Atom and all of them seem to break long words when necessary.

About the same as before, but with line breaking. Here's an example that has some red.

Switch to unicode 'word joiner' (essentially a non-breaking zero-width space) so there's no extra line break when a line starts a really long word. Now looks like:

Old appearance:

Ooh! No, I didn't know about arc branch. I do think being able to say arc land D123 would also be useful.

Thanks for this!

Yeah, we're at ced70f6b32785cf5e522466df91085e066987719 (Mar 16).

Thank you!

I don't feel super strongly, but am happy to see it back -- thanks. :)

If the revision summary is empty, the mail messages now look a little awkward:

Nothing concrete as I have no idea how anything is implemented yet. :) There's no practical way to hide the tooltips when the button it's coming from is removed?

(Maybe Dashboard was the wrong project for this? Looks like you're not a member of that project so maybe you won't see this unless I CC you now…)