Page MenuHomePhabricator

Closing a comment editor doesn't dismiss editor button tooltips
Closed, ResolvedPublic

Description

If you're making an inline comment, hover over an editor button like the full screen one, then submit the comment using the keyboard, then the tooltip hangs around indefinitely:

{F126657}

I can take a stab at fixing this when I have some time.

Revisions and Commits

Event Timeline

sophiebits claimed this task.
sophiebits raised the priority of this task from to Needs Triage.
sophiebits updated the task description. (Show Details)
sophiebits added a project: Differential.
sophiebits added a subscriber: epriestley.

The only reasonable way I can see to fix this is to hide all tooltips on any keypress -- do you have a better approach in mind?

Nothing concrete as I have no idea how anything is implemented yet. :) There's no practical way to hide the tooltips when the button it's coming from is removed?

We could walk the DOM when a node is removed, but we don't need to do this for anything else right now, and I don't anticipate needing to do it in the future. It also seems like the sort of thing that could create performance problems down the line or hide greater peril than is apparent at first glance (offhand, maybe memory leaks from reference cycles if we aren't careful about how the node -> tip link is represented).

The "any keystroke hides it" rule has the benefit of being dramatically simpler if we can get away with it, although it's definitely kind of an approximation. Offhand, I can't think of anything it would break, though.

epriestley edited this Maniphest Task.Mar 12 2014, 1:30 PM
epriestley closed this task as Resolved.Mar 13 2014, 1:31 AM