Page MenuHomePhabricator

Allow "Track Only" and "Autoclose" to accept regular expressions
ClosedPublic

Authored by epriestley on Aug 25 2014, 11:09 PM.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP912b4c564d6f: Allow "Track Only" and "Autoclose" to accept regular expressions
Summary

Fixes T2564. See screenshot.

Test Plan

  • Made a bunch of valid and invalid adjustments here and verified that the branches table showed autoclose state and branches consistent with the settings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow "Track Only" and "Autoclose" to accept regular expressions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
shrey added a subscriber: shrey.Aug 26 2014, 9:33 AM
shrey removed a subscriber: shrey.
epriestley updated this revision to Diff 24921.Aug 26 2014, 5:06 PM
  • Add validation checks for regex(...), quack(...), etc.
btrahan accepted this revision.Aug 26 2014, 8:00 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2014, 8:00 PM
epriestley closed this revision.Aug 26 2014, 8:29 PM
epriestley updated this revision to Diff 24927.

Closed by commit rP912b4c564d6f (authored by @epriestley).