Page MenuHomePhabricator

Editing `list<string>` configuration can be perplexing
Closed, ResolvedPublic

Description

For config options like files.image-mime-types, when edited from the web UI the correct value is something like:

example/a
example/b

However, the existing values are shown in JSON:

{
  "example/a" : true,
  "example/b" : true
}

If you copy/paste the JSON, you end up with a completely bogus configuration.

We should probably show the current value in the same format, and possibly provide examples. This is sort of hard to validate because strings can contain any characters other than newlines.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Setup.
epriestley added a subscriber: epriestley.

I got confused by this a couple days ago too.

epriestley edited this Maniphest Task.Apr 8 2014, 6:56 PM
epriestley edited this Maniphest Task.Apr 8 2014, 7:09 PM
epriestley closed this task as Resolved.Apr 8 2014, 7:09 PM

Closed by commit rPf79320e64e8f.