Page MenuHomePhabricator

Include storyText in feed POST data
ClosedPublic

Authored by sophiebits on Apr 5 2014, 5:52 AM.

Details

Summary

I also changed PhabricatorApplicationTransactionFeedStory and the TokenGivenFeedStory to include only the title/first line of the feed story, which is more convenient (previously, strip_tags gave a multi-line story without even any linebreaks) and more consistent with the other story types.

Test Plan

Added a requestbin URL to feed.http-hooks, commented on a Differential, and saw storyText equal to "alpert added a comment to D2: c." in the POST data it received.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 20656.Apr 5 2014, 5:52 AM
sophiebits retitled this revision from to Include storyText in feed POST data.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley.
epriestley accepted this revision.Apr 6 2014, 6:48 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Apr 6 2014, 6:48 PM
epriestley closed this revision.Apr 6 2014, 6:48 PM
epriestley updated this revision to Diff 20660.

Closed by commit rPcd829434d49d (authored by @spicyj, committed by @epriestley).